Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 24, 2025

Overview

This PR adds .NET 10.0 support to all project files and GitHub Actions workflows, preparing the repository for the upcoming .NET 10 release.

Changes

Project Files

Both ImageSharpCompare.csproj and ImageSharpCompareTestNunit.csproj now unconditionally target .NET 10.0:

<TargetFrameworks>net8.0;net9.0;net10.0</TargetFrameworks>

This approach ensures that projects will always target net8.0, net9.0, and net10.0 once the .NET 10 SDK is available.

GitHub Actions Workflow

Updated .github/workflows/dotnet.yml to include .NET 10.0.x SDK in all three jobs:

  • Build job: Tests on ubuntu, macos, and windows with .NET 8.0.x, 9.0.x, and 10.0.x
  • DeployRelease job: Builds and publishes releases with all three SDK versions
  • DeployTest job: Builds and publishes test packages with all three SDK versions

Testing

  • ✅ CodeQL security analysis passed (0 vulnerabilities)
  • ✅ No breaking changes to existing functionality

Notes

.NET 10.0 SDK is not yet released (expected November 2025). Once the .NET 10 SDK becomes available, the CI workflows will automatically begin building and testing for all three target frameworks.

This pull request was created as a result of the following prompt from Copilot chat.

Update all project files in the repository to add net10.0 to the TargetFrameworks or TargetFramework property, if not already present. Also, update any GitHub Actions workflow files (e.g., .github/workflows/build.yml) to include .NET SDK version 10.0.x in the build matrix or setup-dotnet steps, ensuring CI builds and tests for .NET 10 as well.

Make these updates for all mainline projects and the primary CI build workflow.

Original prompt

Update all project files in the repository to add net10.0 to the TargetFrameworks or TargetFramework property, if not already present. Also, update any GitHub Actions workflow files (e.g., .github/workflows/build.yml) to include .NET SDK version 10.0.x in the build matrix or setup-dotnet steps, ensuring CI builds and tests for .NET 10 as well.

Make these updates for all mainline projects and the primary CI build workflow.

This pull request was created as a result of the following prompt from Copilot chat.

Update all project files in the repository to add net10.0 to the TargetFrameworks or TargetFramework property, if not already present. Also, update any GitHub Actions workflow files (e.g., .github/workflows/build.yml) to include .NET SDK version 10.0.x in the build matrix or setup-dotnet steps, ensuring CI builds and tests for .NET 10 as well.

Make these updates for all mainline projects and the primary CI build workflow.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@github-actions
Copy link
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copilot AI and others added 2 commits October 24, 2025 11:36
Co-authored-by: stesee <168659+stesee@users.noreply.github.com>
Co-authored-by: stesee <168659+stesee@users.noreply.github.com>
Copilot AI changed the title [WIP] Update project files to include net10.0 in TargetFrameworks Add .NET 10.0 support to project files and CI workflow Oct 24, 2025
Copilot AI requested a review from stesee October 24, 2025 11:42
@stesee
Copy link
Collaborator

stesee commented Oct 24, 2025

@copilot remove sdk version conditions in csproj, always build. Net 10

Co-authored-by: stesee <168659+stesee@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Oct 24, 2025

@copilot remove sdk version conditions in csproj, always build. Net 10

Removed SDK version conditions from both csproj files. Projects now unconditionally target net8.0, net9.0, and net10.0. (dc7a2a6)

@stesee stesee marked this pull request as ready for review October 24, 2025 12:27
Copilot AI review requested due to automatic review settings October 24, 2025 12:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds .NET 10.0 as a target framework to prepare the repository for the upcoming .NET 10 release (expected November 2025). The changes ensure that once the .NET 10 SDK is available, the codebase will automatically build and test against it alongside existing .NET 8.0 and 9.0 targets.

Key Changes:

  • Added net10.0 to TargetFrameworks in both project files
  • Updated CI workflow to include .NET 10.0.x SDK in all build, deployment, and testing jobs

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
ImageSharpCompare/ImageSharpCompare.csproj Added net10.0 to target frameworks for the main library project
ImageSharpCompareTestNunit/ImageSharpCompareTestNunit.csproj Added net10.0 to target frameworks for the test project
.github/workflows/dotnet.yml Added .NET 10.0.x SDK to all three CI jobs (build, deploy release, deploy test)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@stesee stesee merged commit d114dd9 into main Oct 24, 2025
5 of 7 checks passed
@stesee stesee deleted the copilot/update-targetframework-to-net10 branch October 24, 2025 12:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants