-
-
Notifications
You must be signed in to change notification settings - Fork 12
Add .NET 10.0 support to project files and CI workflow #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Co-authored-by: stesee <168659+stesee@users.noreply.github.com>
Co-authored-by: stesee <168659+stesee@users.noreply.github.com>
|
@copilot remove sdk version conditions in csproj, always build. Net 10 |
Co-authored-by: stesee <168659+stesee@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds .NET 10.0 as a target framework to prepare the repository for the upcoming .NET 10 release (expected November 2025). The changes ensure that once the .NET 10 SDK is available, the codebase will automatically build and test against it alongside existing .NET 8.0 and 9.0 targets.
Key Changes:
- Added
net10.0toTargetFrameworksin both project files - Updated CI workflow to include .NET 10.0.x SDK in all build, deployment, and testing jobs
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ImageSharpCompare/ImageSharpCompare.csproj | Added net10.0 to target frameworks for the main library project |
| ImageSharpCompareTestNunit/ImageSharpCompareTestNunit.csproj | Added net10.0 to target frameworks for the test project |
| .github/workflows/dotnet.yml | Added .NET 10.0.x SDK to all three CI jobs (build, deploy release, deploy test) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Overview
This PR adds .NET 10.0 support to all project files and GitHub Actions workflows, preparing the repository for the upcoming .NET 10 release.
Changes
Project Files
Both
ImageSharpCompare.csprojandImageSharpCompareTestNunit.csprojnow unconditionally target .NET 10.0:This approach ensures that projects will always target net8.0, net9.0, and net10.0 once the .NET 10 SDK is available.
GitHub Actions Workflow
Updated
.github/workflows/dotnet.ymlto include .NET 10.0.x SDK in all three jobs:Testing
Notes
.NET 10.0 SDK is not yet released (expected November 2025). Once the .NET 10 SDK becomes available, the CI workflows will automatically begin building and testing for all three target frameworks.
This pull request was created as a result of the following prompt from Copilot chat.
Original prompt
This pull request was created as a result of the following prompt from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.