Fix infinite callback loop and equality check

Author: benceruleanlu

src/components/graph/vueWidgets/WidgetTextarea.vue

@@ -14,7 +14,7 @@
 import Textarea from 'primevue/textarea'
 import { computed } from 'vue'
 
-import { useWidgetValue } from '@/composables/graph/useWidgetValue'
+import { useStringWidgetValue } from '@/composables/graph/useWidgetValue'
 import type { SimplifiedWidget } from '@/types/simplifiedWidget'
 import {
   INPUT_EXCLUDED_PROPS,
@@ -32,12 +32,11 @@ const emit = defineEmits<{
 }>()
 
 // Use the composable for consistent widget value handling
-const { localValue, onChange } = useWidgetValue({
-  widget: props.widget,
-  modelValue: props.modelValue,
-  defaultValue: '',
+const { localValue, onChange } = useStringWidgetValue(
+  props.widget,
+  props.modelValue,
   emit
-})
+)
 
 const filteredProps = computed(() =>
   filterWidgetProps(props.widget.options, INPUT_EXCLUDED_PROPS)

src/composables/graph/useGraphNodeManager.ts

@@ -270,29 +270,42 @@ export const useGraphNodeManager = (graph: LGraph): GraphNodeManager => {
     originalCallback: ((value: unknown) => void) | undefined,
     nodeId: string
   ) => {
+    let updateInProgress = false
+
     return (value: unknown) => {
-      // 1. Update the widget value in LiteGraph (critical for LiteGraph state)
-      // Validate that the value is of an acceptable type
-      if (
-        value !== null &&
-        value !== undefined &&
-        typeof value !== 'string' &&
-        typeof value !== 'number' &&
-        typeof value !== 'boolean' &&
-        typeof value !== 'object'
-      ) {
-        console.warn(`Invalid widget value type: ${typeof value}`)
-        return
-      }
-      widget.value = value
+      // Prevent circular callbacks - bulletproof recursion guard
+      if (updateInProgress) return
+      updateInProgress = true
 
-      // 2. Call the original callback if it exists
-      if (originalCallback) {
-        originalCallback.call(widget, value)
-      }
+      try {
+        // 1. Update the widget value in LiteGraph (critical for LiteGraph state)
+        // Validate that the value is of an acceptable type
+        if (
+          value !== null &&
+          value !== undefined &&
+          typeof value !== 'string' &&
+          typeof value !== 'number' &&
+          typeof value !== 'boolean' &&
+          typeof value !== 'object'
+        ) {
+          console.warn(`Invalid widget value type: ${typeof value}`)
+          updateInProgress = false
+          return
+        }
+
+        // Always update widget.value to ensure sync
+        widget.value = value
 
-      // 3. Update Vue state to maintain synchronization
-      updateVueWidgetState(nodeId, widget.name, value)
+        // 2. Call the original callback if it exists
+        if (originalCallback) {
+          originalCallback.call(widget, value)
+        }
+
+        // 3. Update Vue state to maintain synchronization
+        updateVueWidgetState(nodeId, widget.name, value)
+      } finally {
+        updateInProgress = false
+      }
     }
   }
 

src/composables/graph/useWidgetValue.ts

@@ -81,11 +81,6 @@ export function useWidgetValue<T extends WidgetValue = WidgetValue, U = T>({
 
     // 2. Emit to parent component
     emit('update:modelValue', processedValue)
-
-    // 3. Call LiteGraph callback to update authoritative state
-    if (widget.callback) {
-      widget.callback(processedValue)
-    }
   }
 
   // Watch for external updates from LiteGraph