Skip to content

Commit d76f3e8

Browse files
christian-byrnebenceruleanlu
authored andcommitted
fix: npm link in release notification comment (#6683)
Changes to correct URL syntax for npm package link (types package). ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6683-fix-npm-link-in-release-notification-comment-2aa6d73d365081729c54efabc76a833a) by [Unito](https://www.unito.io)
1 parent 2955913 commit d76f3e8

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/actions/comment-release-links/action.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,11 @@ runs:
5757
package.json)
5858
LINKS_VALUE=$(printf '%s\n%s' \
5959
'PyPI|https://pypi.org/project/comfyui-frontend-package/{{version}}/' \
60-
'npm types|https://npm.im/@comfyorg/comfyui-frontend-types@{{version}}')
60+
'npm types|https://www.npmjs.com/package/@comfyorg/comfyui-frontend-types/v/{{version}}')
6161
;;
6262
apps/desktop-ui/package.json)
6363
MARKER='desktop-release-summary'
64-
LINKS_VALUE='npm desktop UI|https://npm.im/@comfyorg/desktop-ui@{{version}}'
64+
LINKS_VALUE='npm desktop UI|https://www.npmjs.com/package/@comfyorg/desktop-ui/v/{{version}}'
6565
;;
6666
esac
6767
@@ -74,7 +74,7 @@ runs:
7474
echo "<!--$MARKER:$DIFF_PREFIX$NEW_VERSION-->"
7575
echo "$MESSAGE"
7676
echo ""
77-
echo "- $DIFF_LABEL: [$DIFF_PREFIX$PREV_VERSION...$DIFF_PREFIX$NEW_VERSION]($DIFF_URL)"
77+
echo "- $DIFF_LABEL: [\`$DIFF_PREFIX$PREV_VERSION...$DIFF_PREFIX$NEW_VERSION\`]($DIFF_URL)"
7878
7979
while IFS= read -r RAW_LINE; do
8080
LINE=$(echo "$RAW_LINE" | sed 's/^[[:space:]]*//;s/[[:space:]]*$//')
@@ -87,7 +87,7 @@ runs:
8787
URL_TEMPLATE=${LINE#*|}
8888
URL=${URL_TEMPLATE//\{\{version\}\}/$NEW_VERSION}
8989
URL=${URL//\{\{prev_version\}\}/$PREV_VERSION}
90-
echo "- $LABEL: $URL"
90+
echo "- $LABEL: [\`$NEW_VERSION\`]($URL)"
9191
done <<< "$LINKS_VALUE"
9292
9393
echo ""

0 commit comments

Comments
 (0)