libreorama lightorama/protocol.h issue

[gogo6211]

I know this inst the right repo but the libreorama is archived and I am 99% sure that the error I'm getting isn't user error. I've tried almost everything including trying to get chatgpt to help, using older version of liblorproto, and going through the code and commit history and I have found nothing referencing "lightorama/protocol.h" anywhere besides the sequence.h file in libeorama. This issue is being caused when running Make So any idea what happing or how to fix this?

dawson@raspberrypi:~/Downloads/libreorama-master $ make
[  6%] Building C object CMakeFiles/libreorama.dir/src/main.c.o
In file included from /home/dawson/Downloads/libreorama-master/src/player/player.h:30,
                 from /home/dawson/Downloads/libreorama-master/src/main.c:33:
/home/dawson/Downloads/libreorama-master/src/player/sequence.h:27:10: fatal error: lightorama/protocol.h: No such file or directory
   27 | #include <lightorama/protocol.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/libreorama.dir/build.make:76: CMakeFiles/libreorama.dir/src/main.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/libreorama.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
dawson@raspberrypi:~/Downloads/libreorama-master $ 

[Cryptkeeper]

I gave this a quick spin and dug up liblightorama (now liblorproto) @ 99144c54556b5b1ebc40429edb160c5eee112514. Having checked out, built and installing that git commit; libreorama appears to compile (at its current head) without issue. Best of luck!

[gogo6211]

Thanks! will have to try this later today. The protocol.h file has shimmer and twinkle in it but just want to confirm that will work since its not mentioned in the readme.md. Also lor_brightness_curve_squared is the default used by libreorama since it's here right?

[gogo6211]

That fixed it thanks. Now I have an issue with libxml

[  6%] Building C object CMakeFiles/libreorama.dir/src/seqtypes/lormedia.c.o
In file included from /home/dawson/Downloads/libreorama-master/src/seqtypes/lormedia.c:26:
/home/dawson/Downloads/libreorama-master/src/seqtypes/loreffect.h:27:10: fatal error: libxml/tree.h: No such file or directory
   27 | #include <libxml/tree.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/libreorama.dir/build.make:146: CMakeFiles/libreorama.dir/src/seqtypes/lormedia.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/libreorama.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

I see the tree.h file is at /usr/include/libxml2/libxml and it passed all the test from make check when installing libxml so idk whats going on. Is this user error or a bug I should report to the libxml devs?