-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
bugSomething isn't workingSomething isn't working
Description
| ta.adc_peak = latest_tp_in_window.adc_peak; |
The assignment of the ADC peak for this algorithm is not true to the TP contents. There is no calculation done for what the ADC peak actually is since it strictly uses the last TP in the window. This may be true of other algorithms which make use of TPWindow, but I have not yet checked.
It may be worth it to keep track of the argmax of ADC peak for the TP list in TPWindow for easier updating for the moving window and assignment during TA construction.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working