Don't panic in the case that the tree structure isn't as-expected (i.e. the "invariant" we expect is incorrect)

Author: jasonforal

crates/static-analysis-kernel/src/analysis/languages/java/imports.rs

@@ -113,15 +113,23 @@ pub fn parse_imports_with_tree<'text>(
             }
         }
 
-        let package_node = package_node.expect("query invariant: value should be Some");
-        let target = target.expect("query invariant: value should be Some");
+        let Some(package_node) = package_node else {
+            debug_assert!(false, "query invariant: value should be Some");
+            continue;
+        };
+        let Some(target) = target else {
+            debug_assert!(false, "query invariant: value should be Some");
+            continue;
+        };
         // Due to the way the tree-sitter-java grammar is defined, when there is an asterisk, what
         // we've captured as the `import_child` will represent the full text of the package.
         // Otherwise, what we've captured as `package` will.
+        let Some(import_child_node) = import_child_node else {
+            debug_assert!(false, "query invariant: value should be Some");
+            continue;
+        };
         let package = match target {
-            ImportTarget::Wildcard => {
-                import_child_node.expect("query invariant: value should be Some")
-            }
+            ImportTarget::Wildcard => import_child_node,
             ImportTarget::Class(_) => package_node,
         };
         imports.push(Import { package, target });

crates/static-analysis-kernel/src/analysis/languages/javascript/imports.rs

@@ -216,8 +216,10 @@ pub(crate) fn parse_imports_with_tree_inner<'text>(
                 name = imported_from.take();
             }
 
+            debug_assert!(name.is_some(), "name should always be set");
+            let name = name?;
             Some(PackageImport {
-                name: name.expect("name should always be set"),
+                name,
                 imported_from,
             })
         })

crates/static-analysis-kernel/src/analysis/languages/python/imports.rs

@@ -104,9 +104,10 @@ impl<'a> Import<'a> {
     /// from ..common_utils.local_utils import print_array # Some(Import("common_utils"))
     /// ```
     pub fn parent_import(&self) -> Option<Import<'a>> {
-        self.full_text.rsplit_once('.').map(|(parent, _)| {
-            Import::try_new(parent, None, None, self.is_relative)
-                .expect("full_text should not have whitespace")
+        self.full_text.rsplit_once('.').and_then(|(parent, _)| {
+            let import = Import::try_new(parent, None, None, self.is_relative);
+            debug_assert!(import.is_ok());
+            import.ok()
         })
     }
 }