Fix restriction_policy_resource_id format for private locations (#3310)

Fix restriction_policy_resource_id format for private locations

The computed field was generating the wrong format, causing restriction
policies to appear as "Unrestricted" in the UI despite being created
successfully in Terraform.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Co-authored-by: matt.cameron <matt.cameron@datadoghq.com>

Author: Matt-Cam

datadog/fwprovider/resource_datadog_synthetics_private_location.go

@@ -268,7 +268,11 @@ func (r *syntheticsPrivateLocationResource) updateState(ctx context.Context, sta
 	state.Description = types.StringValue(resp.GetDescription())
 	state.Name = types.StringValue(resp.GetName())
 	state.Tags, _ = types.ListValueFrom(ctx, types.StringType, resp.Tags)
-	state.RestrictionPolicyResourceId = types.StringValue(fmt.Sprintf("synthetics-private-location%s", resp.GetId()[2:]))
+	// Convert the private location ID to the format expected by restriction policies
+	// The format should be: synthetics-private-location:pl:xxx (keep the pl: prefix)
+	privateLocationId := resp.GetId()
+	restrictionPolicyId := fmt.Sprintf("synthetics-private-location:%s", privateLocationId)
+	state.RestrictionPolicyResourceId = types.StringValue(restrictionPolicyId)
 
 	if metadata, ok := resp.GetMetadataOk(); ok {
 		if restrictedRoles, ok := metadata.GetRestrictedRolesOk(); ok {

datadog/tests/resource_datadog_synthetics_private_location_test.go

@@ -102,7 +102,7 @@ func createSyntheticsPrivateLocationStep(ctx context.Context, accProvider *fwpro
 				"datadog_synthetics_private_location.foo", "config"),
 			resource.TestCheckResourceAttrSet(
 				"datadog_synthetics_private_location.foo", "id"),
-			checkRessourceAttributeRegex("datadog_synthetics_private_location.foo", "restriction_policy_resource_id", "synthetics-private-location:.*"),
+			checkRessourceAttributeRegex("datadog_synthetics_private_location.foo", "restriction_policy_resource_id", "synthetics-private-location:pl:.*"),
 		),
 	}
 }
@@ -141,7 +141,7 @@ func updateSyntheticsPrivateLocationStep(ctx context.Context, accProvider *fwpro
 				"datadog_synthetics_private_location.foo", "config"),
 			resource.TestCheckResourceAttrSet(
 				"datadog_synthetics_private_location.foo", "id"),
-			checkRessourceAttributeRegex("datadog_synthetics_private_location.foo", "restriction_policy_resource_id", "synthetics-private-location:.*"),
+			checkRessourceAttributeRegex("datadog_synthetics_private_location.foo", "restriction_policy_resource_id", "synthetics-private-location:pl:.*"),
 		),
 	}
 }