Skip to content

Commit 03c8f38

Browse files
committed
Fix image ROI not updating after editing bounds
1 parent a2a0c32 commit 03c8f38

File tree

5 files changed

+466
-361
lines changed

5 files changed

+466
-361
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,9 @@ for future and past milestones.
4444
is now fixed by using the "spawn" method instead, which is the recommended method for
4545
latest versions of Python on Linux when multithreading is involved.
4646
* Fixed [Issue #60](https://github.com/DataLab-Platform/DataLab/issues/60) - `OSError: Invalid HDF5 file [...]` when trying to open an HDF5 file with an extension other than ".h5"
47+
* Image Region of Interest (ROI) extraction: when modifying the image bounds in the
48+
confirmation dialog box, the ROI was not updated accordingly until the operation was
49+
run again
4750
* Deprecation issues:
4851
* Fixed `scipy.ndimage.filters` deprecation warning
4952
* Fixed `numpy.fromstring` deprecation warning

cdl/core/gui/processor/base.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -815,6 +815,7 @@ def edit_regions_of_interest(
815815
):
816816
roidata = obj.params_to_roidata(roigroup)
817817
if roieditordata.modified:
818+
roieditordata.roidata = roidata
818819
# If ROI has been modified, save ROI (even in "extract mode")
819820
obj.roi = roidata
820821
self.SIG_ADD_SHAPE.emit(obj.uuid)

0 commit comments

Comments
 (0)