Merge branch 'master' into smooth_normal_calculation

Author: kevyuu

.gitconfig

@@ -0,0 +1,2 @@
+[alias]
+    devsh = "!f() { git -c submodule.ci.update=checkout -c submodule.Ditt-Reference-Scenes.update=checkout \"$@\"; }; f"

.github/workflows/build-nabla.yml

@@ -345,3 +345,44 @@ jobs:
           
           $token = '${{ secrets.CE_IMAGE_UPDATE_TOKEN }}'
           Invoke-UpdateImages -Token $token
+
+  smoke-tests:
+    name: Nabla / Smoke (${{ matrix.os }}, ${{ matrix.vendor }}-latest, ${{ matrix.config }})
+    needs: build-windows
+    runs-on: windows-2022
+    strategy:
+      fail-fast: false
+      matrix:
+        config: [Release, Debug, RelWithDebInfo]
+        os: [windows-2022]
+        vendor: [msvc]
+    steps:
+      - name: Checkout smoke
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+          sparse-checkout: |
+            smoke
+
+      - name: Download Nabla install artifact
+        uses: actions/download-artifact@v4
+        with:
+          name: run-windows-17.13.6-msvc-${{ matrix.config }}-install
+          path: smoke
+
+      - name: Unpack Nabla install artifact
+        run: |
+          $tar = Get-ChildItem smoke -Filter *-install.tar -File | Select-Object -First 1
+          if (-not $tar) { throw "install tar not found in smoke" }
+          tar -xf $tar.FullName -C smoke
+          if (-not (Test-Path "smoke/build-ct/install")) { throw "smoke/build-ct/install not found" }
+          tree.com smoke /F
+
+      - name: Configure Smoke
+        run: cmake -S smoke -B smoke/out
+
+      - name: Build Smoke
+        run: cmake --build smoke/out --config ${{ matrix.config }}
+
+      - name: CTest Smoke
+        run: ctest --test-dir smoke/out --force-new-ctest-process --output-on-failure --no-tests=error -C ${{ matrix.config }}

.gitignore

@@ -16,6 +16,7 @@
 # usually where people build
 android_build/*
 build*/*
+smoke/*build*/*
 # default install paths
 install/*
 # legacy temporary and output directories
@@ -36,3 +37,4 @@ tools/nsc/bin/*
 */__pycache__/*
 __pycache__/*
 *.pyc
+

.gitmodules

@@ -121,3 +121,8 @@
 [submodule "3rdparty/gtl"]
 	path = 3rdparty/gtl
 	url = https://github.com/greg7mdp/gtl.git
+[submodule "ci"]
+	path = ci
+	url = git@github.com:Devsh-Graphics-Programming/Nabla-CI.git
+	branch = ditt
+	update = none

3rdparty/CMakeLists.txt

@@ -292,6 +292,9 @@ option(GIT_EXCLUDE_IS_DIRTY "Exclude IS_DIRTY from git tracking checks, will inc
 add_subdirectory(git-version-tracking EXCLUDE_FROM_ALL)
 NBL_ADD_GIT_TRACKING_META_LIBRARY(nabla "${NBL_ROOT_PATH}")
 NBL_ADD_GIT_TRACKING_META_LIBRARY(dxc "${CMAKE_CURRENT_SOURCE_DIR}/dxc/dxc")
+nbl_install_file("${CMAKE_CURRENT_BINARY_DIR}/git-version-tracking/nabla_git_info.json")
+nbl_install_file("${CMAKE_CURRENT_BINARY_DIR}/git-version-tracking/dxc_git_info.json")
+
 NBL_GENERATE_GIT_TRACKING_META()
 
 # NGFX
@@ -522,7 +525,27 @@ add_dependencies(3rdparty ${NBL_3RDPARTY_TARGETS})
 
 NBL_ADJUST_FOLDERS(3rdaprty)
 
-nbl_install_dir("${CMAKE_CURRENT_SOURCE_DIR}/gtl/include")
+nbl_install_dir(Vulkan-Headers/include/vulkan)
+nbl_install_dir(Vulkan-Headers/include/vk_video)
+
+nbl_install_file_spec(volk/volk.h volk)
+
+nbl_install_dir(gtl/include/gtl)
+nbl_install_dir(glm/glm)
+
+nbl_install_file_spec(${CMAKE_CURRENT_BINARY_DIR}/imath/config/ImathConfig.h imath)
+nbl_install_dir(imath/src/Imath)
+
+nbl_install_file(blake/c/blake3.h)
+
+nbl_install_file_spec(nlohmann_json/include/nlohmann/json_fwd.hpp nlohmann)
+nbl_install_file_spec(nlohmann_json/include/nlohmann/detail/abi_macros.hpp nlohmann/detail)
+
+nbl_install_dir(boost/superproject/libs/preprocessor/include/boost)
+
+nbl_install_file_spec(renderdoc/renderdoc_app.h renderdoc)
+
+nbl_install_file(${CMAKE_CURRENT_BINARY_DIR}/git-version-tracking/git_info.h)
 
 # parent scope exports, must be at the end of the file
 set(_NBL_3RDPARTY_TARGETS_ 

3rdparty/dxc/dxc

@@ -20,17 +20,25 @@ NBL_POLICY(CMP0112 NEW) # https://cmake.org/cmake/help/latest/policy/CMP0112.htm
 NBL_POLICY(CMP0141 NEW) # https://cmake.org/cmake/help/latest/policy/CMP0141.html#policy:CMP0141
 NBL_POLICY(CMP0118 NEW) # https://cmake.org/cmake/help/latest/policy/CMP0118.html#policy:CMP0118
 
+set(CMAKE_CXX_SCAN_FOR_MODULES OFF) # https://cmake.org/cmake/help/latest/prop_tgt/CXX_SCAN_FOR_MODULES.html#prop_tgt:CXX_SCAN_FOR_MODULES
+
 set(NBL_BUILD_ANDROID OFF)
 
 include(ExternalProject)
 include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/toolchains/android/build.cmake)
 
-project(Nabla LANGUAGES CXX C)
+project(Nabla
+	VERSION 0.8.0.1 
+	HOMEPAGE_URL "https://www.devsh.eu/nabla"
+	LANGUAGES CXX C
+)
 enable_language(C CXX ASM ASM_NASM)
 
+include(GNUInstallDirs)
+include(CMakePackageConfigHelpers)
+
 if(MSVC)
 	enable_language(ASM_MASM)
-	link_libraries(delayimp)
 endif()
 
 # TODO: TO BE KILLED, keep both in one tree
@@ -154,31 +162,16 @@ if(_NBL_AVAILABLE_PHYSICAL_MEMORY_ LESS_EQUAL _NBL_DEBUG_MEMORY_CONSUPTION_WITH_
 	else()
 		set(_NBL_CMAKE_STATUS_ FATAL_ERROR)
 	endif()
-	
+
 	message(${_NBL_CMAKE_STATUS_} "Memory consumption issue detected! To protect you from compile and linker errors, please read this message.\n\nYour total physical memory is ${_NBL_TOTAL_PHYSICAL_MEMORY_} MBs, your OS is currently using ${_NBL_CURRENTLY_USED_PHYSICAL_MEMORY_} MBs and consumption of your memory with requested ${_NBL_JOBS_AMOUNT_} jobs in Debug configuration may be around ${_NBL_DEBUG_MEMORY_CONSUPTION_WITH_ALL_JOBS_} MBs. Please override '_NBL_JOBS_AMOUNT_' variable by setting it as cache variable and lower the jobs! If you want to continue anyway, please define 'NBL_MEMORY_CONSUMPTION_CHECK_SKIP' but be aware - you are doing it on your own risk of possible build failures.")
 endif()
 
 include(adjust/flags)
 include(adjust/definitions)
 
-if(WIN32)
-	set(_NBL_PLATFORM_WINDOWS_ 1)
-elseif(ANDROID)
-	set(_NBL_PLATFORM_ANDROID_ 1)
-elseif(UNIX)
-	set(_NBL_PLATFORM_LINUX_ 1)
-	set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -msse4.1")
-endif()
-
-if(NBL_STATIC_BUILD)
-	unset(_NBL_SHARED_BUILD_ CACHE)
-else()
-	set(_NBL_SHARED_BUILD_ ON CACHE INTERNAL "")
-endif()
-
 option(NBL_BUILD_DPL "Enable DPL (Dynamic Parallelism Library)" OFF)
 option(NBL_PCH "Enable pre-compiled header" ON)
-option(NBL_FAST_MATH "Enable fast low-precision math" ON)
+option(NBL_FAST_MATH "Enable fast low-precision math" OFF) # the reason OFF is by default now is the var controling it at build time was set AFTER BuildConfigOptions was generated - resulting in the feature being always OFF regardless the value xD - so just for sanity, keeping the same behaviour by default
 option(NBL_BUILD_EXAMPLES "Enable building examples" ON)
 option(NBL_BUILD_MITSUBA_LOADER "Enable nbl::ext::MitsubaLoader?" OFF) # TODO: once it compies turn this ON by default!
 option(NBL_BUILD_IMGUI "Enable nbl::ext::ImGui?" ON)
@@ -286,4 +279,43 @@ option(NBL_CPACK_INCLUDE_EXAMPLES "CPack with examples and media" ON)
 include(cpack/package)
 include(build/info)
 export(TARGETS ${_NBL_3RDPARTY_TARGETS_} Nabla NAMESPACE Nabla:: APPEND FILE ${NBL_ROOT_PATH_BINARY}/NablaExport.cmake)
-NBL_ADJUST_FOLDERS(nabla)
+
+option(NBL_ENABLE_CONFIG_INSTALL "Install Relocatable NablaConfig.cmake and NablaConfigVersion.cmake scripts" ON)
+
+if(NBL_ENABLE_CONFIG_INSTALL)
+	if(NBL_STATIC_BUILD)
+		message(WARNING "Ignoring NBL_ENABLE_CONFIG_INSTALL due to: TODO, static builds are not relocatable yet!")
+	else()
+		install(TARGETS Nabla
+			EXPORT NablaExportTargets
+			ARCHIVE  DESTINATION ${_NBL_CPACK_PACKAGE_RELATIVE_ENTRY_}/lib
+			LIBRARY  DESTINATION ${_NBL_CPACK_PACKAGE_RELATIVE_ENTRY_}/lib
+			RUNTIME  DESTINATION ${_NBL_CPACK_PACKAGE_RELATIVE_ENTRY_}/runtime/nbl
+		)
+
+		write_basic_package_version_file(
+			"${CMAKE_CURRENT_BINARY_DIR}/NablaConfigVersion.cmake"
+			VERSION ${PROJECT_VERSION}
+			COMPATIBILITY SameMinorVersion
+		)
+
+		configure_package_config_file(
+			"${CMAKE_CURRENT_LIST_DIR}/cmake/NablaConfig.cmake.in"
+			"${CMAKE_CURRENT_BINARY_DIR}/NablaConfig.cmake"
+			INSTALL_DESTINATION cmake
+		)
+
+		install(EXPORT NablaExportTargets
+			NAMESPACE Nabla::
+			DESTINATION cmake
+		)
+
+		install(FILES
+			"${CMAKE_CURRENT_BINARY_DIR}/NablaConfig.cmake"
+			"${CMAKE_CURRENT_BINARY_DIR}/NablaConfigVersion.cmake"
+			DESTINATION cmake
+		)
+	endif()
+endif()
+
+NBL_ADJUST_FOLDERS(nabla)

3rdparty/git-version-tracking

@@ -10,6 +10,7 @@ add_custom_target(pack_artifact_ditt
 	COMMAND cmake -E echo "Archiving the build!"
 	COMMAND cmake -E copy ${EXAMPLES_TESTS_PATH}/${NBL_RAYTRACEDAO_EX_NAME}/bin/LowDiscrepancySequenceCache.bin ${CMAKE_CURRENT_BINARY_DIR}/Ditt/pack/${NBL_RAYTRACEDAO_EX_NAME}/bin/LowDiscrepancySequenceCache.bin
 	COMMAND cmake -E copy ${EXAMPLES_TESTS_PATH}/${NBL_RAYTRACEDAO_EX_NAME}/bin/raytracedao.exe ${CMAKE_CURRENT_BINARY_DIR}/Ditt/pack/${NBL_RAYTRACEDAO_EX_NAME}/bin/raytracedao.exe
+	COMMAND cmake -E copy ${EXAMPLES_TESTS_PATH}/${NBL_RAYTRACEDAO_EX_NAME}/addEnvironmentEmitters.comp ${CMAKE_CURRENT_BINARY_DIR}/Ditt/pack/${NBL_RAYTRACEDAO_EX_NAME}/addEnvironmentEmitters.comp
 	COMMAND cmake -E copy ${EXAMPLES_TESTS_PATH}/${NBL_RAYTRACEDAO_EX_NAME}/closestHit.comp ${CMAKE_CURRENT_BINARY_DIR}/Ditt/pack/${NBL_RAYTRACEDAO_EX_NAME}/closestHit.comp
 	COMMAND cmake -E copy ${EXAMPLES_TESTS_PATH}/${NBL_RAYTRACEDAO_EX_NAME}/common.h ${CMAKE_CURRENT_BINARY_DIR}/Ditt/pack/${NBL_RAYTRACEDAO_EX_NAME}/common.h
 	COMMAND cmake -E copy ${EXAMPLES_TESTS_PATH}/${NBL_RAYTRACEDAO_EX_NAME}/cull.comp ${CMAKE_CURRENT_BINARY_DIR}/Ditt/pack/${NBL_RAYTRACEDAO_EX_NAME}/cull.comp