-
Notifications
You must be signed in to change notification settings - Fork 25
Open
Description
Make the following changes found during a code review of the Card component:
- Change title proptype to allow .node
- At minimum, change standardFieldset to fieldset and always use title instead of needed legend ... maybe just kill fieldset option (and legend)
- At maximum, kill fieldset
- pass through ...others, use blacklist if necessary
- Pass ...others into wrapper div or fieldset
- kill cardBody on line 24, put wrapper div and {children} in line 43
- Replace null on line 45 with block from lines 29-32
- Only render {card} and kill line 49
- Possibly pull out card logic from render function into function
- Kill React.Fragment and call new card method
Tests
- Line 28 change Accordion to Card
- Kill test on line 38
- Add unit tests
Metadata
Metadata
Assignees
Labels
No labels