Skip to content

Icon Review Updates #996

@Darper

Description

@Darper

Make the following changes found during a code review of the Icon component:

  • Update classes in docs from "fa" to "fab"
  • Update docs to tell user to include their own icon library and update classes
  • Include code snippet to show how to use font-awesome
  • Mark icon prop as required
  • Remove console.warn on line 14
  • Allow ...others
  • Remove onClick as it is included in ...others
  • Change large to compose from .font-size-1 and small to use .font-size-5

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions