[DYN-9230] Bump dynamo major version check for PackageManager. (#16428)

Author: reddyashish

src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerClientViewModel.cs

@@ -950,7 +950,7 @@ internal async void ExecutePackageDownload(string name, PackageVersion package,
                     // also identify packages that have a dynamo engine version less than 3.x as a special case,
                     // as Dynamo 3.x uses .net8 and older versions used .net framework - these packages may not be compatible.
                     // This check will return empty if the current major version is not 3.
-                    var preDYN3Deps = newPackageHeaders.Where(dep => dynamoVersion.Major == 3 && Version.Parse(dep.engine_version).Major < dynamoVersion.Major);
+                    var preDYN4Deps = newPackageHeaders.Where(dep => dynamoVersion.Major == 4 && Version.Parse(dep.engine_version).Major < dynamoVersion.Major);
 
                     // If any of the required packages use a newer version of Dynamo, show a dialog to the user
                     // allowing them to cancel the package download
@@ -971,7 +971,7 @@ internal async void ExecutePackageDownload(string name, PackageVersion package,
 
                     //if any of the required packages use a pre 3.x version of Dynamo, show a dialog to the user
                     //allowing them to cancel the package download
-                    if (preDYN3Deps.Any())
+                    if (preDYN4Deps.Any())
                     {
                         var res = MessageBoxService.Show(ViewModelOwner,
                         $"{string.Format(Resources.MessagePackageOlderDynamo, DynamoViewModel.BrandingResourceProvider.ProductName)} {Resources.MessagePackOlderDynamoLink}",

src/DynamoPackages/PackageLoader.cs

@@ -276,7 +276,7 @@ private void TryLoadPackageIntoLibrary(Package package)
                 Log($"Loaded Package {package.Name} {package.VersionName} from {package.RootDirectory}");
                 try
                 {
-                    if (dynamoVersion.Major == 3 && Version.Parse(package.EngineVersion).Major < 3)
+                    if (dynamoVersion.Major == 4 && Version.Parse(package.EngineVersion).Major < 3)
                     {
                         Log($@"{package.Name} {package.VersionName} has an engine version of {package.EngineVersion},
                         it may not be compatible with this version of Dynamo due to .NET runtime changes. ");