Fix few warnings as found by PhpStorm

Author: PowerKiKi

README.md

@@ -11,7 +11,7 @@
 A library to declare GraphQL types from Doctrine entities, PHP 7.1 type hinting,
 and annotations, and to be used with [webonyx/graphql-php](https://github.com/webonyx/graphql-php).
 
-It reads most informations from type hints, complete some things from existing
+It reads most information from type hints, complete some things from existing
 Doctrine annotations and allow further customizations with specialized annotations.
 It will then create [`ObjectType`](https://webonyx.github.io/graphql-php/type-system/object-types/#object-type-definition) and
  [`InputObjectType`](https://webonyx.github.io/graphql-php/type-system/input-types/#input-object-type)

composer.json

@@ -6,6 +6,9 @@
         "check": [
             "php-cs-fixer fix --ansi --dry-run --diff",
             "phpunit --color=always"
+        ],
+        "fix": [
+            "php-cs-fixer fix --ansi"
         ]
     },
     "autoload": {

src/Definition/EntityID.php

@@ -41,6 +41,8 @@ public function __construct(EntityManager $entityManager, string $className, ?st
     /**
      * Get the entity from DB
      *
+     * @throws Error
+     *
      * @return mixed entity
      */
     public function getEntity()

src/Definition/EntityIDType.php

@@ -80,6 +80,8 @@ public function parseLiteral($valueNode)
     /**
      * Create EntityID to retrieve entity from DB later on
      *
+     * @param string $id
+     *
      * @return mixed entity
      */
     private function createEntityID(string $id)

src/Factory/AbstractFieldsConfigurationFactory.php

@@ -228,7 +228,7 @@ protected function getTypeFromReturnTypeHint(ReflectionMethod $method, string $f
             return $type;
         }
 
-        return $this->refelectionTypeToType($returnType);
+        return $this->reflectionTypeToType($returnType);
     }
 
     /**
@@ -239,7 +239,7 @@ protected function getTypeFromReturnTypeHint(ReflectionMethod $method, string $f
      *
      * @return Type
      */
-    protected function refelectionTypeToType(ReflectionType $reflectionType, bool $isEntityId = false): Type
+    protected function reflectionTypeToType(ReflectionType $reflectionType, bool $isEntityId = false): Type
     {
         $type = $this->getTypeFromRegistry((string) $reflectionType, $isEntityId);
         if (!$reflectionType->allowsNull()) {
@@ -287,7 +287,7 @@ protected function getMethodFullName(ReflectionMethod $method): string
     protected function throwIfArray(ReflectionParameter $param, ?string $type): void
     {
         if ($type === 'array') {
-            throw new Exception('The parameter `$' . $param->getName() . '` on method ' . $this->getMethodFullName($param->getDeclaringFunction()) . ' is type hinted as `array` and is not overriden via `@API\Argument` annotation. Either change the type hint or specify the type with `@API\Argument` annotation.');
+            throw new Exception('The parameter `$' . $param->getName() . '` on method ' . $this->getMethodFullName($param->getDeclaringFunction()) . ' is type hinted as `array` and is not overridden via `@API\Argument` annotation. Either change the type hint or specify the type with `@API\Argument` annotation.');
         }
     }
 
@@ -319,13 +319,13 @@ private function getTargetEntity(string $fieldName): ?string
      * Returns a type from our registry
      *
      * @param string $type
-     * @param bool $isEntityid
+     * @param bool $isEntityId
      *
      * @return Type
      */
-    private function getTypeFromRegistry(string $type, bool $isEntityid): Type
+    private function getTypeFromRegistry(string $type, bool $isEntityId): Type
     {
-        if (!$this->types->isEntity($type) || !$isEntityid) {
+        if (!$this->types->isEntity($type) || !$isEntityId) {
             return $this->types->get($type);
         }
 
@@ -354,6 +354,7 @@ protected function nonNullIfHasDefault(ReflectionParameter $param, ?Type $type):
      *
      * @param ReflectionParameter $param
      * @param Type $type
+     * @param string $annotation
      *
      * @throws Exception
      */

src/Factory/AbstractTypeFactory.php

@@ -34,7 +34,7 @@ public function __construct(Types $types, EntityManager $entityManager)
      *
      * @param string $className class name of Doctrine entity
      *
-     * @return ObjectType
+     * @return Type
      */
     abstract public function create(string $className): Type;
 

src/Factory/InputFieldsConfigurationFactory.php

@@ -92,7 +92,7 @@ private function completeField(ReflectionMethod $method, ReflectionParameter $pa
         $type = $param->getType();
         if (!$field->type && $type) {
             $this->throwIfArray($param, (string) $type);
-            $field->type = $this->refelectionTypeToType($type, true);
+            $field->type = $this->reflectionTypeToType($type, true);
         }
 
         $field->type = $this->nonNullIfHasDefault($param, $field->type);

src/Factory/OutputFieldsConfigurationFactory.php

@@ -107,6 +107,7 @@ private function completeField(ReflectionMethod $method, Field $field): void
      *
      * @param ReflectionMethod $method
      * @param Argument[] $argsFromAnnotations
+     * @param DocBlockReader $docBlock
      *
      * @throws Exception
      *
@@ -161,7 +162,7 @@ private function completeArgumentFromTypeHint(ReflectionMethod $method, Reflecti
         $type = $param->getType();
         if (!$arg->type && $type) {
             $this->throwIfArray($param, (string) $type);
-            $arg->type = $this->refelectionTypeToType($type, true);
+            $arg->type = $this->reflectionTypeToType($type, true);
         }
 
         $arg->type = $this->nonNullIfHasDefault($param, $arg->type);

src/Types.php

@@ -160,6 +160,8 @@ private function createInstance(string $className): Type
     /**
      * Checks if a className is a valid doctrine entity
      *
+     * @param string $className
+     *
      * @return bool
      */
     public function isEntity(string $className): bool

tests/Blog/Model/Post.php

@@ -40,7 +40,7 @@ class Post extends AbstractModel
     private $publicationDate;
 
     /**
-     * @var bool
+     * @var string
      *
      * @ORM\Column(type="string", options={"default" = Post::STATUS_PRIVATE})
      */
@@ -57,8 +57,6 @@ class Post extends AbstractModel
      * Set title
      *
      * @param string $title
-     *
-     * @return User
      */
     public function setTitle(string $title): void
     {
@@ -79,8 +77,6 @@ public function getTitle(): string
      * Set the body
      *
      * @param string $body
-     *
-     * @return User
      */
     public function setBody(string $body): void
     {
@@ -105,8 +101,6 @@ public function getBody(): string
      * @API\Input(type="GraphQLTests\Doctrine\Blog\Types\PostStatusType")
      *
      * @param string $status
-     *
-     * @return User
      */
     public function setStatus(string $status = self::STATUS_PUBLIC): void
     {