Happy Stan

Author: PowerKiKi

phpstan.neon.dist

@@ -18,7 +18,6 @@ parameters:
         - '~^Parameter #3 \$subject of function preg_replace expects array\|string, string\|null given\.$~'
         - '~^Parameter #2 \$str of function explode expects string, string\|null given\.$~'
         - '~^Parameter #1 \$str of function ucfirst expects string, string\|null given\.$~'
-        - '~^Method GraphQL\\Doctrine\\Utils::getTypeName\(\) should return string but returns string\|false\.$~'
         - '~^Parameter #2 \$type of method GraphQL\\Doctrine\\Factory\\AbstractFieldsConfigurationFactory::adjustNamespace\(\) expects string, string\|null given\.$~'
         - '~^Parameter #1 \$driver of method Doctrine\\Persistence\\Mapping\\Driver\\MappingDriverChain\:\:setDefaultDriver\(\) expects Doctrine\\Persistence\\Mapping\\Driver\\MappingDriver, Doctrine\\Persistence\\Mapping\\Driver\\MappingDriver\|null given\.$~'
         - '~^Parameter #1 \$argument of class ReflectionClass constructor expects class\-string\<T of object\>\|T of object, string given\.$~'

src/Factory/AbstractFieldsConfigurationFactory.php

@@ -205,6 +205,7 @@ final protected function reflectionTypeToType(ReflectionNamedType $reflectionTyp
     private function findIdentityField(string $className): void
     {
         $this->metadata = $this->entityManager->getClassMetadata($className);
+        /** @var array $meta */
         foreach ($this->metadata->fieldMappings as $meta) {
             if ($meta['id'] ?? false) {
                 $this->identityField = $meta['fieldName'];

src/Factory/MetadataReader/MappingDriverChainAdapter.php

@@ -45,85 +45,36 @@ private function findReader(ReflectionClass $class): Reader
         throw new Exception('graphql-doctrine requires ' . $className . ' entity to be configured with a `' . AnnotationDriver::class . '`.');
     }
 
-    /**
-     * Gets the annotations applied to a class.
-     *
-     * @param ReflectionClass $class the ReflectionClass of the class from which
-     *                                the class annotations should be read
-     *
-     * @return array an array of Annotations
-     */
     public function getClassAnnotations(ReflectionClass $class)
     {
         return $this->findReader($class)
             ->getClassAnnotations($class);
     }
 
-    /**
-     * Gets a class annotation.
-     *
-     * @param ReflectionClass $class the ReflectionClass of the class from which
-     *                                         the class annotations should be read
-     * @param string $annotationName the name of the annotation
-     *
-     * @return null|object the Annotation or NULL, if the requested annotation does not exist
-     */
     public function getClassAnnotation(ReflectionClass $class, $annotationName)
     {
         return $this->findReader($class)
             ->getClassAnnotation($class, $annotationName);
     }
 
-    /**
-     * Gets the annotations applied to a method.
-     *
-     * @param ReflectionMethod $method the ReflectionMethod of the method from which
-     *                                  the annotations should be read
-     *
-     * @return array an array of Annotations
-     */
     public function getMethodAnnotations(ReflectionMethod $method)
     {
         return $this->findReader($method->getDeclaringClass())
             ->getMethodAnnotations($method);
     }
 
-    /**
-     * Gets a method annotation.
-     *
-     * @param ReflectionMethod $method the ReflectionMethod to read the annotations from
-     * @param string $annotationName the name of the annotation
-     *
-     * @return null|object the Annotation or NULL, if the requested annotation does not exist
-     */
     public function getMethodAnnotation(ReflectionMethod $method, $annotationName)
     {
         return $this->findReader($method->getDeclaringClass())
             ->getMethodAnnotation($method, $annotationName);
     }
 
-    /**
-     * Gets the annotations applied to a property.
-     *
-     * @param ReflectionProperty $property the ReflectionProperty of the property
-     *                                      from which the annotations should be read
-     *
-     * @return array an array of Annotations
-     */
     public function getPropertyAnnotations(ReflectionProperty $property)
     {
         return $this->findReader($property->getDeclaringClass())
             ->getPropertyAnnotations($property);
     }
 
-    /**
-     * Gets a property annotation.
-     *
-     * @param ReflectionProperty $property the ReflectionProperty to read the annotations from
-     * @param string $annotationName the name of the annotation
-     *
-     * @return null|object the Annotation or NULL, if the requested annotation does not exist
-     */
     public function getPropertyAnnotation(ReflectionProperty $property, $annotationName)
     {
         return $this->findReader($property->getDeclaringClass())

src/Factory/Type/FilterGroupConditionTypeFactory.php

@@ -58,6 +58,7 @@ public function create(string $className, string $typeName): Type
                 $this->readCustomOperatorsFromAnnotation($metadata->reflClass);
 
                 // Get all scalar fields
+                /** @var array $mapping */
                 foreach ($metadata->fieldMappings as $mapping) {
 
                     // Skip exclusion specified by user

src/Utils.php

@@ -38,7 +38,11 @@ public static function getOperatorTypeName(string $className, LeafType $type): s
     /**
      * Return an array of all annotations found in the class hierarchy, including its traits, indexed by the class name
      *
+     * @param class-string<T> $annotationName
+     *
      * @return array annotations indexed by the class name where they were found
+     *
+     * @template T
      */
     public static function getRecursiveClassAnnotations(Reader $reader, ReflectionClass $class, string $annotationName): array
     {