Skip to content

Commit 305544a

Browse files
Merge pull request #579 from tub5/bug/578
Upgrade to use Electron 12.0.12
2 parents fdd643b + 78d9d60 commit 305544a

File tree

4 files changed

+1792
-11
lines changed

4 files changed

+1792
-11
lines changed

ElectronNET.API/Entities/WebPreferences.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,8 +185,8 @@ public class WebPreferences
185185
/// Context' entry in the combo box at the top of the Console tab. This option is
186186
/// currently experimental and may change or be removed in future Electron releases.
187187
/// </summary>
188-
[DefaultValue(false)]
189-
public bool ContextIsolation { get; set; }
188+
[DefaultValue(true)]
189+
public bool ContextIsolation { get; set; } = true;
190190

191191
/// <summary>
192192
/// Whether to use native window.open(). Defaults to false. This option is currently experimental.

ElectronNET.CLI/Commands/BuildCommand.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ public Task<bool> ExecuteAsync()
198198
: $"node build-helper.js {manifestFileName} {version}", tempPath);
199199

200200
Console.WriteLine($"Package Electron App for Platform {platformInfo.ElectronPackerPlatform}...");
201-
ProcessHelper.CmdExecute($"npx electron-builder --config=./bin/electron-builder.json --{platformInfo.ElectronPackerPlatform} --{electronArch} -c.electronVersion=11.1.1 {electronParams}", tempPath);
201+
ProcessHelper.CmdExecute($"npx electron-builder --config=./bin/electron-builder.json --{platformInfo.ElectronPackerPlatform} --{electronArch} -c.electronVersion=12.0.12 {electronParams}", tempPath);
202202

203203
Console.WriteLine("... done");
204204

0 commit comments

Comments
 (0)