Skip to content

Commit ea7d155

Browse files
authored
Merge pull request #2 from sinankeskin/master
Fix Windows environment set issue and change to env to params for compatibility
2 parents 48f1b5d + 7c0a4cc commit ea7d155

File tree

1 file changed

+16
-12
lines changed

1 file changed

+16
-12
lines changed

index.js

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,16 @@ module.exports = {
3535
const assetsDir = this.readConfig('assetsDir');
3636

3737
this.log('SENTRY: Creating release...');
38-
this.sentryCliExec(`releases new ${releaseName}`);
38+
this.sentryCliExec('releases', `new ${releaseName}`);
3939

4040
this.log('SENTRY: Assigning commits...');
41-
this.sentryCliExec(`releases set-commits --auto ${releaseName}`);
41+
this.sentryCliExec('releases', `set-commits --auto ${releaseName}`);
4242

4343
this.log('SENTRY: Uploading source maps...');
44-
this.sentryCliExec(`releases files ${releaseName} upload-sourcemaps --rewrite ${assetsDir}`);
44+
this.sentryCliExec('releases', `files ${releaseName} upload-sourcemaps --rewrite ${assetsDir}`);
4545

4646
this.log('SENTRY: Finalizing release...');
47-
this.sentryCliExec(`releases finalize ${releaseName}`);
47+
this.sentryCliExec('releases', `finalize ${releaseName}`);
4848

4949
this.log('SENTRY: Release published!...');
5050
},
@@ -55,7 +55,7 @@ module.exports = {
5555
const environment = this.readConfig('environment');
5656

5757
this.log('SENTRY: Deploying release...');
58-
this.sentryCliExec(`releases deploys ${releaseName} new -e ${environment}`);
58+
this.sentryCliExec('releases', `deploys ${releaseName} new -e ${environment}`);
5959
this.log('SENTRY: Deployed!');
6060
},
6161

@@ -64,22 +64,26 @@ module.exports = {
6464
const releaseName = `${appName}@${this.readConfig('revisionKey')}`;
6565

6666
this.log('SENTRY: Deleting release...');
67-
this.sentryCliExec(`releases delete ${releaseName}`);
67+
this.sentryCliExec('releases', `delete ${releaseName}`);
6868
this.log('SENTRY: Release deleted!');
6969
},
7070

71-
sentryCliExec(command) {
71+
sentryCliExec(command, subCommand) {
7272
const authToken = this.readConfig('authToken');
7373
const orgName = this.readConfig('orgName');
7474
const appName = this.readConfig('appName');
7575
const url = this.readConfig('url');
7676

7777
return this._exec(
78-
url ? `SENTRY_URL=${url} ` : '' +
79-
`SENTRY_ORG=${orgName} ` +
80-
`SENTRY_PROJECT=${appName} ` +
81-
`SENTRY_AUTH_TOKEN=${authToken} ` +
82-
`node_modules/.bin/sentry-cli ${command}`
78+
[
79+
path.join('node_modules', '.bin', 'sentry-cli'),
80+
url ? `--url ${url}` : '',
81+
`--auth-token ${authToken}`,
82+
command,
83+
`--org ${orgName}`,
84+
`--project ${appName}`,
85+
subCommand
86+
].join(' ')
8387
);
8488
},
8589

0 commit comments

Comments
 (0)