Skip to content

Change default sort of pool search from 'score' to 'roa' #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Change default sort of pool search from 'score' to 'roa' #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af8ed40
Change default sort of pool search from 'score' to 'roa' to encourage…
Jun 20, 2025
edb300e
Merge branch 'master' into master
vsubhuman Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/API/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ const toPoolArray: (?{| [string]: Pool |}) => Array<Pool> = (pools) => {

export function getPools(body: SearchParams): Promise<ApiPoolsResponse> {
const requestBody = {
...{ search: '', sort: Sorting.SCORE, limit: 250 },
...{ search: '', sort: Sorting.ROA, limit: 250 },
...body,
};

Expand Down
8 changes: 4 additions & 4 deletions src/components/SortSelect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,14 +48,14 @@ type Props = {|
|};

export const sortingSelectData = [
{ label: 'Score', value: Sorting.SCORE }, // default option on load
{ label: 'ROA', value: Sorting.ROA }, // default option on load
{ label: 'Ticker and name', value: Sorting.TICKER },
];

export const sortingSelectDataRevamp = [
{ label: 'Score', value: Sorting.SCORE }, // default option on load
{ label: 'ROA', value: Sorting.ROA }, // default option on load
{ label: 'Score', value: Sorting.SCORE },
{ label: 'Ticker and name', value: Sorting.TICKER },
{ label: 'ROA', value: Sorting.ROA },
{ label: 'Pool size', value: Sorting.POOL_SIZE },
{ label: 'Saturation', value: Sorting.SATURATION },
{ label: 'Costs', value: Sorting.COSTS },
Expand All @@ -64,7 +64,7 @@ export const sortingSelectDataRevamp = [
];

function SortSelect({ filter, isRevamp = true, isDark }: Props): React$Node {
const [selectValue, setSelectValue] = React.useState<SortingEnum>('score');
const [selectValue, setSelectValue] = React.useState<SortingEnum>('roa');

const handleChange = (e) => {
setSelectValue(e.currentTarget.value);
Expand Down
2 changes: 1 addition & 1 deletion src/containers/Home.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ function Home(props: HomeProps): Node {
const [status, setStatus] = React.useState<QueryState>('idle');
const [filterOptions, setFilterOptions] = React.useState<SearchParams>({
search: '',
sort: 'score',
sort: 'roa',
});
const [openModal, setOpenModal] = React.useState<boolean>(false);
const [confirmDelegationModal, setConfirmDelegationModal] = React.useState<boolean>(false);
Expand Down
2 changes: 1 addition & 1 deletion src/containers/HomeRevamp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ function Home(props: HomeProps): Node {
const [status, setStatus] = React.useState<QueryState>('idle');
const [filterOptions, setFilterOptions] = React.useState<SearchParams>({
search: '',
sort: Sorting.SCORE,
sort: Sorting.ROA,
sortDirection: SortingDirections.ASC,
});
const [openModal, setOpenModal] = React.useState<boolean>(false);
Expand Down