update: add test coverage for listToString tag

Author: unsigned6

tests/enums.ts

@@ -2,6 +2,7 @@ import * as path from "path";
 
 export const FIXTURES_DIR = path.resolve(__dirname, "./fixtures");
 export const YAML_COMBINE_FILE = path.resolve(FIXTURES_DIR, "yaml_combine_tag.yml");
+export const YAML_LIST_TO_STRING_FILE = path.resolve(FIXTURES_DIR, "yaml_listToString_tag.yml");
 export const YAML_PARAMETER_FILE = path.resolve(FIXTURES_DIR, "yaml_parameter_tag.yml");
 export const YAML_ESSE_FILE = path.resolve(FIXTURES_DIR, "yaml_esse_tag.yml");
 export const YAML_INCLUDE_FILE = path.resolve(FIXTURES_DIR, "yaml_include_tag.yml");

tests/fixtures/yaml_listToString_tag.yml

@@ -1,4 +1,14 @@
 # listToString content from another Yaml file
 case1:
     here: original content
-    there: !listToString "tests/fixtures/yaml_parameter_ref.yml#/job/workflow"
+    there: !listToString
+        - one # comment 1
+        - two # comment 2
+case2:
+    here: original content
+    there: !listToString
+        - one # comment 1
+        - 1 # non-string ignored
+        - some: 1 # object also skipped
+          other: "object"
+        - two # comment 2

tests/utils/yaml.listToString.tests.ts

@@ -3,20 +3,31 @@ import { expect } from "chai";
 import fs from "fs";
 import yaml from "js-yaml";
 
-import { includeType } from "../../src/utils/yaml";
-import { YAML_INCLUDE_FILE } from "../enums";
+import { listToStringType } from "../../src/utils/yaml";
+import { YAML_LIST_TO_STRING_FILE } from "../enums";
 
-const includeSchema = yaml.DEFAULT_SCHEMA.extend([includeType]);
+const includeSchema = yaml.DEFAULT_SCHEMA.extend([listToStringType]);
 
-describe.only("YAML tag: !listToString", () => {
-    const yamlFixture = fs.readFileSync(YAML_INCLUDE_FILE, "utf8");
+describe("YAML tag: !listToString", () => {
+    const yamlFixture = fs.readFileSync(YAML_LIST_TO_STRING_FILE, "utf8");
 
     it("should correctly concatenate content from list to string", () => {
         const parsed = yaml.load(yamlFixture, { schema: includeSchema });
+
         const expected = {
             here: "original content",
-            there: ["run", "stop", "pause"],
+            there: "onetwo",
         };
         expect(parsed.case1).to.be.eql(expected);
     });
+
+    it("should correctly filter out and concatenate only strings from list", () => {
+        const parsed = yaml.load(yamlFixture, { schema: includeSchema });
+
+        const expected = {
+            here: "original content",
+            there: "onetwo",
+        };
+        expect(parsed.case2).to.be.eql(expected);
+    });
 });