Report - Report title is shown as formula after moving IOU repport to WS

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.91-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2626/folder/13176670/41237100/1103226470
Email or phone of affected tester (no customers): ndk.2303+new170@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Critical User Impact
Device used: Windows 11 Home/Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in as the Admin of the workspace
• If the admin does not have 2 workspaces, create another workspace
• Navigate to a 1:1 conversation with any other user
• Submit 2 Expenses to the other user to create an IOU report

1. Open https://staging.new.expensify.com/
2. Navigate to the IOU Report details
3. Click on More
4. Click on "Change Workspace"
5. Select any workspace

Expected Result:

Report Title is updated

Actual Result:

Report title is shown as formula

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7040675_1767373077224.title.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @brianlee-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When an IOU report is moved to a workspace, the report title is displayed as a formula string (e.g., {report:type} - {report:total}) instead of the evaluated title (e.g., Expense Report - $50.00).

What is the root cause of that problem?

The root cause is a mismatch between optimistic data and backend response handling:

1. When moving an IOU report to a workspace, the convertIOUReportToExpenseReport function optimistically sets the reportName field by evaluating the title formula using populateOptimisticReportFormula.
2. The backend API returns the report data with reportName containing the raw formula string (not the evaluated value).
3. Since the backend response uses Onyx.METHOD.MERGE, it overwrites the optimistically evaluated reportName with the formula string.
4. The getMoneyRequestReportName function in ReportNameUtils checks if report?.reportName exists for expense reports and returns it directly without checking if it's a formula that needs evaluation.

This results in the formula being displayed as-is in the UI instead of showing the properly formatted report title.

What changes do you think we should make in order to solve the problem?

We should keep the optimistic reportName evaluation for immediate display, but clear the reportName field in the success data to prevent the backend's formula string from overwriting our evaluated value.

Specifically, in the convertIOUReportToExpenseReport function:

1. Keep the optimistic data that sets expenseReport.reportName = populateOptimisticReportFormula(...)
2. Add a success data entry that sets reportName: null for the report

App/src/libs/actions/Report.ts

Lines 5485 to 5489 in f7265ef

	function convertIOUReportToExpenseReport(iouReport: Report, policy: Policy, policyID: string, optimisticPolicyExpenseChatReportID: string) {
	const optimisticData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.REPORT | typeof ONYXKEYS.COLLECTION.TRANSACTION | typeof ONYXKEYS.COLLECTION.REPORT_ACTIONS>> = [];
	const successData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.REPORT_ACTIONS>> = [];
	const failureData: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.REPORT | typeof ONYXKEYS.COLLECTION.TRANSACTION | typeof ONYXKEYS.COLLECTION.REPORT_ACTIONS>> = [];

update the successData type to allow both REPORT and REPORT_ACTIONS keys.

• Add the following to successData in convertIOUReportToExpenseReport:

successData.push({
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
    value: {
        reportName: null,
    },
});

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When a user moves an IOU/expense report to another workspace via Change Workspace, the report title shows the raw formula text.

What is the root cause of that problem?

• The money request title helper returns the stored report name without resolving workspace title formulas. When the RNVP stores a formula after a workspace move, that raw string shows to the user. See the logic that immediately returns report.reportName for expense reports and never uses the title field configuration:

  App/src/libs/ReportNameUtils.ts

  Lines 307 to 310 in f7265ef

  	function getMoneyRequestReportName({report, policy, invoiceReceiverPolicy}: {report: OnyxEntry<Report>; policy?: OnyxEntry<Policy>; invoiceReceiverPolicy?: OnyxEntry<Policy>}): string {
  	if (report?.reportName && isExpenseReport(report)) {
  	return report.reportName;
  	}

• The getReportName path also calls getMoneyRequestReportName without passing the report name value pairs, so the helper can't read the stored title field data even if it had been populated:

  App/src/libs/ReportUtils.ts

  Lines 5900 to 5902 in f7265ef

  	if (isMoneyRequestReport(report)) {
  	formattedName = getMoneyRequestReportName({report, policy});
  	}

What changes do you think we should make in order to solve the problem?

Resolve and cache report titles from the workspace title field before falling back to the stored report name, so formulas are expanded when showing moved IOU/expense reports.

// Resolve title formulas before falling back to the stored name
const titleField = reportNameValuePairs?.expensify_text_title;
const populateReportNameFromFormula = (formula?: string) =>
    formula ? populateOptimisticReportFormula(formula, report as Parameters<typeof populateOptimisticReportFormula>[1], policyForFormula) : '';
if (titleField?.value) {
    return titleField.value;
}
const nameFromTitleField = populateReportNameFromFormula(titleField?.defaultValue);
if (nameFromTitleField && !REPORT_NAME_FORMULA_REGEX.test(nameFromTitleField)) {
    return nameFromTitleField;
}
if (REPORT_NAME_FORMULA_REGEX.test(report?.reportName ?? '')) {
    const populatedReportName = populateReportNameFromFormula(report?.reportName);
    if (populatedReportName && !REPORT_NAME_FORMULA_REGEX.test(populatedReportName)) {
        return populatedReportName;
    }
}

// Supply RNVP data so formulas can be expanded
if (isMoneyRequestReport(report)) {
    formattedName = getMoneyRequestReportName({report, policy, reportNameValuePairs});
}