Report - Total amount shown as "0,00" when splitting expense offline after currency change

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.91-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-2626/folder/13176791/41237176/1103226528
Email or phone of affected tester (no customers): ibellicotest+2250@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 / Chrome (Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least one workspace.
Prerequisite 2: Default currency is not USD.

1. Open the staging.new.expensify.com website.
2. Open any workspace chat.
3. Create a manual expense.
4. Open the just created expense.
5. Tap on "Amount" field.
6. Edit the currency to "USD"
7. Return to report.
8. Turn off internet connection.
9. Tap on "More" > "Split"
10. Save the splits amount
11. Once redirected to report, note that total amount above expenses is shown as "0,00".

Expected Result:

After splitting an expense, amount on report should still show the correct total of all the expenses.

Actual Result:

After splitting expenses while in offline mode, total amount is displayed as "0,00" if expense currency was previously changed.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7040686_1767374555996.Currency.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[TaduJR]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When splitting an expense offline after changing its currency, the category subtotal displays as "0,00" instead of the correct amount.

What is the root cause of that problem?

The root cause is a two-part issue in the split expense flow:

1. convertedAmount is omitted when creating split transactions:

App/src/libs/actions/IOU/index.ts

Lines 3711 to 3714 in 66de3d6

	if (isSplitExpense && existingTransaction) {
	const {convertedAmount: omittedConvertedAmount, ...existingTransactionWithoutConvertedAmount} = existingTransaction;
	optimisticTransaction = fastMerge(existingTransactionWithoutConvertedAmount, optimisticTransaction, false);
	}

When splitting, the original transaction's convertedAmount is completely discarded. This was intentionally done to fix issue #76078 (doubled totals), but it removes crucial currency conversion data needed for subtotal calculations.

2. calculateGroupTotal skips transactions without convertedAmount when currencies differ:

App/src/libs/ReportLayoutUtils.ts

Lines 37 to 52 in 66de3d6

	function calculateGroupTotal(transactionList: Transaction[], reportCurrency: string): number {
	let total = 0;
	for (const transaction of transactionList) {
	if (isTransactionPendingDelete(transaction)) {
	continue;
	}
	const transactionCurrency = getCurrency(transaction);
	if (transactionCurrency === reportCurrency) {
	total += getAmount(transaction, true, false, true);
	} else if (transaction.convertedAmount) {
	total += getConvertedAmount(transaction);
	}
	}
	return total;
	}

When transactionCurrency !== reportCurrency and convertedAmount is undefined, the transaction is skipped entirely, resulting in a total of 0.

Root Cause Flow:

1. User creates expense in workspace with default currency EUR
2. User edits expense, changes currency to USD - backend calculates convertedAmount (USD value in EUR)
3. User goes offline and splits the expense
4. Split transactions are created at:

App/src/libs/actions/IOU/index.ts

Lines 3711 to 3714 in 66de3d6

	if (isSplitExpense && existingTransaction) {
	const {convertedAmount: omittedConvertedAmount, ...existingTransactionWithoutConvertedAmount} = existingTransaction;
	optimisticTransaction = fastMerge(existingTransactionWithoutConvertedAmount, optimisticTransaction, false);
	}

5. convertedAmount is omitted, split transactions have currency: USD, convertedAmount: undefined
6. In calculateGroupTotal:

App/src/libs/ReportLayoutUtils.ts

Lines 44 to 49 in 66de3d6

	const transactionCurrency = getCurrency(transaction);
	if (transactionCurrency === reportCurrency) {
	total += getAmount(transaction, true, false, true);
	} else if (transaction.convertedAmount) {
	total += getConvertedAmount(transaction);
	}

7. transactionCurrency (USD) !== reportCurrency (EUR) - first condition fails
8. transaction.convertedAmount is undefined - second condition fails
9. Transaction is skipped, total = 0

What changes do you think we should make in order to solve the problem?

Instead of completely discarding convertedAmount, calculate a proportional value for each split transaction based on the original conversion rate.

File: src/libs/actions/IOU/index.ts

Location:

App/src/libs/actions/IOU/index.ts

Lines 3711 to 3714 in 66de3d6

	if (isSplitExpense && existingTransaction) {
	const {convertedAmount: omittedConvertedAmount, ...existingTransactionWithoutConvertedAmount} = existingTransaction;
	optimisticTransaction = fastMerge(existingTransactionWithoutConvertedAmount, optimisticTransaction, false);
	}

Change:

    if (isSplitExpense && existingTransaction) {
-       const {convertedAmount: omittedConvertedAmount, ...existingTransactionWithoutConvertedAmount} = existingTransaction;
+       const {convertedAmount: originalConvertedAmount, ...existingTransactionWithoutConvertedAmount} = existingTransaction;
        optimisticTransaction = fastMerge(existingTransactionWithoutConvertedAmount, optimisticTransaction, false);
+
+       // Calculate proportional convertedAmount for the split based on the original conversion rate
+       const originalAmount = existingTransaction.modifiedAmount ?? existingTransaction.amount;
+       const splitAmount = optimisticTransaction.modifiedAmount ?? optimisticTransaction.amount;
+       if (originalConvertedAmount && originalAmount && splitAmount) {
+           optimisticTransaction.convertedAmount = Math.round((originalConvertedAmount * splitAmount) / originalAmount);
+       }
    }

This preserves the exchange rate from the original transaction and applies it proportionally to each split, ensuring subtotals display correctly in the report currency.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After splitting expenses while in offline mode, total amount is displayed as "0,00" if expense currency was previously changed.

What is the root cause of that problem?

When splitting an expense offline after changing its currency (e.g., from EUR to USD), the report total showed "0,00" because:

reportTotals was calculated using expense.amount (in transaction currency USD)

But the report's total should be in the report's currency (EUR)

The getMoneyRequestInformation function skipped updating iouReport.total when iouReport.currency !== currency

What changes do you think we should make in order to solve the problem?

diff --git a/src/libs/actions/IOU/index.ts b/src/libs/actions/IOU/index.ts
index 81388aa9074..07e47b1491f 100644
--- a/src/libs/actions/IOU/index.ts
+++ b/src/libs/actions/IOU/index.ts
@@ -3620,7 +3620,10 @@ function getMoneyRequestInformation(moneyRequestInformation: MoneyRequestInforma
     } else if (isPolicyExpenseChat) {
         iouReport = {...iouReport};
         // Because of the Expense reports are stored as negative values, we subtract the total from the amount
-        if (iouReport?.currency === currency) {
+        const currenciesMatch = iouReport?.currency === currency;
+        // When newReportTotal is explicitly provided (e.g., for split expenses), it's already calculated in the report's currency,
+        // so we can apply it even when the transaction currency differs from the report currency.
+        if (currenciesMatch || newReportTotal) {
             if (!Number.isNaN(iouReport.total) && iouReport.total !== undefined) {
                 // Use newReportTotal in scenarios where the total is based on more than just the current transaction, and we need to override it manually
                 if (newReportTotal) {
@@ -3632,7 +3635,7 @@ function getMoneyRequestInformation(moneyRequestInformation: MoneyRequestInforma
                 if (!reimbursable) {
                     if (newNonReimbursableTotal !== undefined) {
                         iouReport.nonReimbursableTotal = newNonReimbursableTotal;
-                    } else {
+                    } else if (currenciesMatch) {
                         iouReport.nonReimbursableTotal = (iouReport.nonReimbursableTotal ?? 0) - amount;
                     }
                 }
@@ -14427,6 +14430,13 @@ function updateSplitTransactions({
         }
     }
 
+    // For multi-currency transactions (where transaction currency differs from report currency),
+    // use the original convertedAmount as the report total since splitting doesn't change the total amount.
+    const isMultiCurrency = originalTransactionDetails?.currency && expenseReport?.currency && originalTransactionDetails.currency !== expenseReport.currency;
+    if (isMultiCurrency && originalTransaction?.convertedAmount && expenseReport?.reportID && reportTotals.has(expenseReport.reportID)) {
+        reportTotals.set(expenseReport.reportID, originalTransaction.convertedAmount);
+    }
+
     for (const [index, splitExpense] of splitExpenses.entries()) {
         const existingTransactionID = isReverseSplitOperation ? originalTransactionID : splitExpense.transactionID;
         const splitTransaction = allTransactionsList?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${existingTransactionID}`];

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.