Game freezes when selecting a trait/profession preset

[TheNukaBoy]

Hey mate!

First off this is a great mod. Unfortunately it causes an issue in my new mod.
Whenever I select a preset of traits and profession in the character editor the game freezes.

• I've run my mod alone so its not an compatbility issue
• I've deleted every code my co author added so that only the profession framework related code remains (so its not an infinite loop or something similar)
• I've tried to disable the starting kits because I suspected this could've been it
• I've tried changing the order of the different attributes for my traits and professions

But nothing worked :(
Is this a known issue and can you tell me how to solve it?

If you want to take a look I have added the releavant files to this issue ticket.
If you want to take a look at the complete mod here is the workshop link: https://steamcommunity.com/sharedfiles/filedetails/?id=2919436296

naprofessions.zip

[FWolfe]

Interesting. Seems to be a issue related to

ProfessionFramework.RemoveDefaultProfessions = true

This is a mostly untested (and uncommonly used) feature of the Profession Framework, and without digging deep into the vanilla I'm not sure why It would cause issues on presets (note: it also seems to freeze when you click "reset traits").
Seems odd since all RemoveDefaultProfessions does is bypass the call that adds the vanilla professions.
But I will need to get to the bottom of this when time allows.

A few other minor issues... In the files attached you've done this:

local addProfession = ProfessionFramework.addProfession()
local addTrait = ProfessionFramework.addTrait()

when you should have done this (without the () brackets)

local addProfession = ProfessionFramework.addProfession
local addTrait = ProfessionFramework.addTrait

All proceeding calls to addProfession() in that file will fail (since addProfession is now nil)

However, this is not a issue in your workshop item (the () are not there), but one of your professions insists on adding non-existing items triggering a exception when loading (impossible to continue):
The tribesman profession's adds PrimitiveSurvival. gear which is not included with this mod. If this is from another mod I'd recommend adding it to the list of requirements.

[TheNukaBoy]

First off: Thanks for mentioning addProfession(). I've accidentally left that mistake in and uploaded it to the workshop but I could fix that issue immediatly so you've probably saved me from being bombardet with ungrateful steam messages.

But now the interesting part.
My mod includes a version that does not remove the vanilla traits as well and when testing this it turned out that you are 100% correct with your suspicion. Whenn not using RemoveDefaultProfessions selecting a preset works perfeclty fine!

The weird thing here is though that the mod I took inspiration from also removes the vanilla professions using that function and yet it doesn't have the same issue. This is the mod I'm talking about: https://steamcommunity.com/sharedfiles/filedetails/?id=2856961307

This makes me suspect that the problem is caused by a combination of factors.
Anyways. I hope this helps you pin down the source.

Thanks for you help so far!

[DaNeo61]

RemoveDefaultProfessions in combination with custom added traits to an profession will causes the crash on present selection.
If the Custom trait is removed and just default traits are used, the present load with RemoveDefaultProfessions will work without issues.

//edit: Custom trait needs to be a profession trait to let the game crash!
If the trait is profession = false which can be manualy removed the game wont crash on present load

[NightScale5755]

I'm pretty sure I found the fix:
"RemoveDefaultProfessions" removes the "Unemployed" occupation, which causes this issue for some random reason.
Simply making an "unemployed" occupation seems to fix this bug. At least by my limited testing.
Anyways, I wish ya'll the absolute best.