From 4c790220c631fcef1d8de6110f106f7805eea638 Mon Sep 17 00:00:00 2001 From: Christian Kjaer Laustsen Date: Fri, 31 May 2019 16:16:36 +0200 Subject: [PATCH 1/2] Disabled setting the serviceEndpoint address and port from DAX_ENDPOINT --- src/Backend.js | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Backend.js b/src/Backend.js index af9540e..dc3af8a 100644 --- a/src/Backend.js +++ b/src/Backend.js @@ -28,10 +28,11 @@ try { class Backend { constructor(cluster, serviceEndpoint, maxPendingConnectionPerHost) { // Enforce service endpoint override, if the cluster endpoint is a proxy. - if (process.env.DAX_ENDPOINT) { - serviceEndpoint.port = portMap[serviceEndpoint.address] || serviceEndpoint.port; - serviceEndpoint.address = process.env.DAX_ENDPOINT.split(':')[0]; - } + // DISABLED because we now places lambda's in the VPC itself. + // if (process.env.DAX_ENDPOINT) { + // serviceEndpoint.port = portMap[serviceEndpoint.address] || serviceEndpoint.port; + // serviceEndpoint.address = process.env.DAX_ENDPOINT.split(':')[0]; + // } this.errorCount = 0; this._cluster = cluster; From 388bcd300e3fd3b61128a0340d6cbdac679eeec5 Mon Sep 17 00:00:00 2001 From: Christian Kjaer Laustsen Date: Fri, 31 May 2019 16:36:17 +0200 Subject: [PATCH 2/2] Fix comment mentioning why we disabled the serviceEndpoint from DAX_ENDPOINT functionality --- src/Backend.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Backend.js b/src/Backend.js index dc3af8a..e382f87 100644 --- a/src/Backend.js +++ b/src/Backend.js @@ -28,7 +28,7 @@ try { class Backend { constructor(cluster, serviceEndpoint, maxPendingConnectionPerHost) { // Enforce service endpoint override, if the cluster endpoint is a proxy. - // DISABLED because we now places lambda's in the VPC itself. + // DISABLED because we are now placing lambda's in the VPC itself. // if (process.env.DAX_ENDPOINT) { // serviceEndpoint.port = portMap[serviceEndpoint.address] || serviceEndpoint.port; // serviceEndpoint.address = process.env.DAX_ENDPOINT.split(':')[0];