Renaming of feature added in #137

Author: cowtowncoder

cbor/src/main/java/com/fasterxml/jackson/dataformat/cbor/CBORParser.java

@@ -48,22 +48,23 @@ public enum Feature implements FormatFeature
         DECODE_USING_STANDARD_NEGATIVE_BIGINT_ENCODING(false),
 
         /**
-         * Feature that determines how an {@code undefined} value ({@code 0xF7}) is decoded.
+         * Feature that determines how an {@code undefined} value ({@code 0xF7}) is exposed
+         * by parser.
          * <p>
-         * When enabled, the parser returns {@link JsonToken#VALUE_EMBEDDED_OBJECT} with a
-         * value of {@code null}, allowing the caller to distinguish {@code undefined} from actual
+         * When enabled, the parser returns {@link JsonToken#VALUE_EMBEDDED_OBJECT} with
+         * a value of {@code null}, allowing the caller to distinguish {@code undefined} from actual
          * {@link JsonToken#VALUE_NULL}.
-         * When disabled (default, for backwards compatibility), {@code undefined} value is
-         * reported as {@link JsonToken#VALUE_NULL}, maintaining legacy behavior
-         * in use up to Jackson 2.19.
+         * When disabled {@code undefined} value is reported as {@link JsonToken#VALUE_NULL}.
+         *<p>
+         * The default value is {@code false} for backwards compatibility (with versions prior to 2.20).
          *
          * @since 2.20
          */
-        HANDLE_UNDEFINED_AS_EMBEDDED_OBJECT(false)
+        READ_UNDEFINED_AS_EMBEDDED_OBJECT(false)
         ;
 
-        final boolean _defaultState;
-        final int _mask;
+        private final boolean _defaultState;
+        private final int _mask;
 
         /**
          * Method that calculates bit set (flags) of all features that
@@ -206,7 +207,7 @@ public int getFirstTag() {
      * @since 2.20
      */
     protected int _formatFeatures;
-    
+
     /**
      * Codec used for data binding when (if) requested.
      */
@@ -1933,7 +1934,7 @@ private final byte[] _getBinaryFromString(Base64Variant variant) throws IOExcept
      * Checking whether the current token represents an `undefined` value (0xF7).
      * <p>
      * This method allows distinguishing between real {@code null} and `undefined`,
-     * even if {@link CBORParser.Feature#HANDLE_UNDEFINED_AS_EMBEDDED_OBJECT} is disabled
+     * even if {@link CBORParser.Feature#READ_UNDEFINED_AS_EMBEDDED_OBJECT} is disabled
      * and the token is reported as {@link JsonToken#VALUE_NULL}.
      *
      * @return {@code true} if current token is an `undefined`, {@code false} otherwise
@@ -3694,14 +3695,14 @@ private final static long _long(int i1, int i2)
      * as {@link JsonToken#VALUE_NULL} by default.
      * <p>
      *
-     * since 2.20 If {@link CBORParser.Feature#HANDLE_UNDEFINED_AS_EMBEDDED_OBJECT} is enabled,
+     * since 2.20 If {@link CBORParser.Feature#READ_UNDEFINED_AS_EMBEDDED_OBJECT} is enabled,
      * the value will instead be decoded as {@link JsonToken#VALUE_EMBEDDED_OBJECT}
      * with an embedded value of {@code null}.
      *
      * @since 2.10
      */
     protected JsonToken _decodeUndefinedValue() {
-        if (Feature.HANDLE_UNDEFINED_AS_EMBEDDED_OBJECT.enabledIn(_formatFeatures)) {
+        if (Feature.READ_UNDEFINED_AS_EMBEDDED_OBJECT.enabledIn(_formatFeatures)) {
             _binaryValue = null; // should be clear but just in case
             return JsonToken.VALUE_EMBEDDED_OBJECT;
         }

cbor/src/test/java/com/fasterxml/jackson/dataformat/cbor/parse/UndefinedValueTest.java

@@ -32,7 +32,7 @@ public void testUndefinedLiteralStreaming() throws Exception
     @Test
     public void testUndefinedLiteralAsEmbeddedObject() throws Exception {
         CBORFactory f = CBORFactory.builder()
-                .enable(CBORParser.Feature.HANDLE_UNDEFINED_AS_EMBEDDED_OBJECT)
+                .enable(CBORParser.Feature.READ_UNDEFINED_AS_EMBEDDED_OBJECT)
                 .build();
         CBORParser p = cborParser(f, new byte[] { BYTE_UNDEFINED });
 
@@ -62,7 +62,7 @@ public void testUndefinedInArray() throws Exception
     @Test
     public void testUndefinedInArrayAsEmbeddedObject() throws Exception {
         CBORFactory f = CBORFactory.builder()
-                .enable(CBORParser.Feature.HANDLE_UNDEFINED_AS_EMBEDDED_OBJECT)
+                .enable(CBORParser.Feature.READ_UNDEFINED_AS_EMBEDDED_OBJECT)
                 .build();
 
         ByteArrayOutputStream out = new ByteArrayOutputStream();
@@ -108,7 +108,7 @@ public void testUndefinedInObject() throws Exception
     @Test
     public void testUndefinedInObjectAsEmbeddedObject() throws Exception {
         CBORFactory f = CBORFactory.builder()
-                .enable(CBORParser.Feature.HANDLE_UNDEFINED_AS_EMBEDDED_OBJECT)
+                .enable(CBORParser.Feature.READ_UNDEFINED_AS_EMBEDDED_OBJECT)
                 .build();
 
         ByteArrayOutputStream out = new ByteArrayOutputStream();

release-notes/VERSION-2.x

@@ -18,8 +18,7 @@ Active maintainers:
 
 #137: (cbor) Allow exposing CBOR "undefined" value as `JsonToken.VALUE_EMBEDDED_OBJECT`;
   with embedded value of `null`
- (implementation contributed by Fawzi E) 
-  
+ (implementation contributed by Fawzi E)
 #431: (cbor) Negative `BigInteger` values not encoded/decoded correctly
  (reported by Brian G)
  (fix contributed by Fawzi E)