Update release notes wrt #109

Author: cowtowncoder

mrbean/pom.xml

@@ -55,7 +55,9 @@ ${project.groupId}.mrbean.*;version=${project.version}
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-compiler-plugin</artifactId>
           <configuration>
-              <!-- Enable testing with Java 8 features, especially default methods in interfaces -->
+              <!-- [modules-base#109] Enable testing with Java 8 features,
+                  especially default methods in interfaces
+                -->
               <testSource>1.8</testSource>
               <testTarget>1.8</testTarget>
           </configuration>

mrbean/src/main/java/com/fasterxml/jackson/module/mrbean/BeanBuilder.java

@@ -182,7 +182,8 @@ protected boolean hasConcreteOverride(Method m0, JavaType implementedType)
         final String name = m0.getName();
         final Class<?>[] argTypes = m0.getParameterTypes();
         try {
-            // getMethod returns the most-specific method implementation, for public methods only (which is any method in an interface)
+            // 22-Sep-2020: [modules-base#109]: getMethod returns the most-specific method
+            //  implementation, for public methods only (which is any method in an interface)
             Method effectiveMethod = implementedType.getRawClass().getMethod(name, argTypes);
             if (BeanUtil.isConcrete(effectiveMethod)) {
                 return true;

mrbean/src/test/java/com/fasterxml/jackson/module/mrbean/TestSimpleMaterializedInterfaces.java

@@ -142,8 +142,7 @@ private Class<?> _materializeRawType(AbstractTypeMaterializer mat,
      */
     public void testSimpleInteface() throws Exception
     {
-        ObjectMapper mapper = new ObjectMapper();
-        mapper.registerModule(new MrBeanModule());
+        ObjectMapper mapper = newMrBeanMapper();
         Bean bean = mapper.readValue("{\"a\":\"value\",\"x\":123 }", Bean.class);
         assertNotNull(bean);
         assertEquals("value", bean.getA());
@@ -155,8 +154,7 @@ public void testSimpleInteface() throws Exception
      */
     public void testBeanHolder() throws Exception
     {
-        ObjectMapper mapper = new ObjectMapper();
-        mapper.registerModule(new MrBeanModule());
+        ObjectMapper mapper = newMrBeanMapper();
         BeanHolder holder = mapper.readValue("{\"bean\":{\"a\":\"b\",\"x\":-4 }}", BeanHolder.class);
         assertNotNull(holder);
         Bean bean = holder.getBean();
@@ -167,8 +165,7 @@ public void testBeanHolder() throws Exception
 
     public void testArrayInterface() throws Exception
     {
-        ObjectMapper mapper = new ObjectMapper();
-        mapper.registerModule(new MrBeanModule());
+        ObjectMapper mapper = newMrBeanMapper();
         ArrayBean bean = mapper.readValue("{\"values\":[1,2,3], \"words\": [ \"cool\", \"beans\" ] }",
                 ArrayBean.class);
         assertNotNull(bean);
@@ -178,15 +175,15 @@ public void testArrayInterface() throws Exception
 
     public void testSubInterface() throws Exception
     {
-        ObjectMapper mapper = new ObjectMapper();
-        mapper.registerModule(new MrBeanModule());
+        ObjectMapper mapper = newMrBeanMapper();
         BeanWithY bean = mapper.readValue("{\"a\":\"b\",\"x\":1, \"y\":2 }", BeanWithY.class);
         assertNotNull(bean);
         assertEquals("b", bean.getA());
         assertEquals(1, bean.getX());
         assertEquals(2, bean.getY());
     }
 
+    // [modules-base#109]
     public void testDefaultMethodInInterface() throws Exception
     {
         ObjectMapper mapper = newMrBeanMapper();
@@ -197,6 +194,7 @@ public void testDefaultMethodInInterface() throws Exception
         assertTrue(bean.anyValuePresent());
     }
 
+    // [modules-base#109]
     public void testInheritedDefaultMethodInInterface() throws Exception
     {
         ObjectMapper mapper = newMrBeanMapper();
@@ -235,7 +233,7 @@ public void testPartialBean() throws Exception
         }
     }
 
-    // As per [JACKSON-683]: fail gracefully if super type not public
+    // Fail gracefully if super type not public
     public void testNonPublic() throws Exception
     {
         ObjectMapper mapper = new ObjectMapper();
@@ -247,5 +245,4 @@ public void testNonPublic() throws Exception
             verifyException(e, "is not public");
         }
     }
-
 }

release-notes/CREDITS-2.x

@@ -50,7 +50,13 @@ Harrison Houghton (hrhino@github)
 
 Bartosz Baranowski (baranowb@github)
 
-* Reported #84: Add expand entity protection and secure processing to
+* Reported #84: (jaxb) Add expand entity protection and secure processing to
   DomElementJsonDeserializer
  (2.10.0)
- 
+
+
+Robby Morgan (robbytx@github)
+
+* Contributed #109: (mrbean) Fix detection of inherited default method in Java 8+ interface
+ (2.11.3)
+

release-notes/VERSION-2.x

@@ -10,6 +10,11 @@ Modules:
 === Releases ===
 ------------------------------------------------------------------------
 
+2.11.3 (not yet released)
+
+#109: (mrbean) Fix detection of inherited default method in Java 8+ interface
+ (contributed by Robby M)
+
 2.11.2 (02-Aug-2020)
 
 - (mrbean / afterburner) Asm version 7.0 -> 7.3.1