Ready fix (#4)

* fix(ready): Fix ready event

Author: panchongyang

WeChat/FeatureProbe.ts

@@ -7,6 +7,11 @@ import { FPToggleDetail, IParams, IOption  } from "./types";
 const PKG_VERSION = 'SDK_VERSION';
 const UA = "WECHAT_MINIPROGRAM/" + PKG_VERSION;
 
+const STATUS = {
+  PENDING: "pending",
+  READY: "ready",
+}
+
 const EVENTS = {
   READY: "ready",
   ERROR: "error",
@@ -22,7 +27,7 @@ class FeatureProbe extends TinyEmitter {
   private toggles: { [key: string]: FPToggleDetail } | null;
   private timer?: NodeJS.Timeout;
   private readyPromise: Promise<void>;
-
+  private status: string;
 
   constructor() {
     super();
@@ -40,6 +45,7 @@ class FeatureProbe extends TinyEmitter {
       };
       this.on(EVENTS.READY, onReadyCallback);
     });
+    this.status = STATUS.PENDING;
   }
 
   public init({
@@ -79,9 +85,11 @@ class FeatureProbe extends TinyEmitter {
 
   public async start() {
     const interval = this.refreshInterval;
-    await this.fetchToggles();
-    this.emit(EVENTS.READY);
-    this.timer = setInterval(() => this.fetchToggles(), interval);
+    try {
+      await this.fetchToggles();
+    } finally {
+      this.timer = setInterval(() => this.fetchToggles(), interval);
+    }
   }
 
   public stop() {
@@ -129,11 +137,11 @@ class FeatureProbe extends TinyEmitter {
   }
 
   public getUser(): FPUser {
-    return Object.assign({}, this.user);
+    return this.user;
   }
 
   public identifyUser(user: FPUser) {
-    this.user = Object.assign({}, user);
+    this.user = user;
   }
 
   public logout() {
@@ -149,6 +157,7 @@ class FeatureProbe extends TinyEmitter {
       user: new FPUser(),
     });
     fp.toggles = toggles;
+    fp.successInitialized();
     return fp;
   }
 
@@ -216,7 +225,7 @@ class FeatureProbe extends TinyEmitter {
     const userParam = Base64.encode(userStr);
     const url = this.togglesUrl;
 
-    await wefetch.get(url, {
+    return wefetch.get(url, {
       cache: "no-cache",
       header: {
         Authorization: this.clientSdkKey,
@@ -228,9 +237,11 @@ class FeatureProbe extends TinyEmitter {
       }
     }).then((response: any) => {
       this.toggles = response.data;
+      this.successInitialized();
       this.emit(EVENTS.UPDATE);
     }).catch((e: any) => {
-      this.emit(EVENTS.ERROR, e);
+      console.error(e);
+      //this.emit(EVENTS.ERROR, e);
     });
   }
 
@@ -269,6 +280,15 @@ class FeatureProbe extends TinyEmitter {
       });
     }
   }
+
+  private successInitialized() {
+    if(this.status === STATUS.PENDING) {
+      this.status = STATUS.READY;
+      setTimeout(() => {
+        this.emit(EVENTS.READY);
+      });
+    }
+  }
 }
 
 const featureProbeClient = new FeatureProbe();

docs/assets/search.js

@@ -18,7 +18,7 @@ <h4>Hierarchy</h4>
 <ul class="tsd-hierarchy">
 <li><span class="target">FPUser</span></li></ul></section><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/FeatureProbe/client-sdk-miniprogram/blob/ca790cf/WeChat/FPUser.ts#L1">WeChat/FPUser.ts:1</a></li></ul></aside>
+<li>Defined in <a href="https://github.com/panchongyang/client-sdk-miniprogram/blob/af52332/WeChat/FPUser.ts#L1">WeChat/FPUser.ts:1</a></li></ul></aside>
 <section class="tsd-panel-group tsd-index-group">
 <section class="tsd-panel tsd-index-panel">
 <details class="tsd-index-content tsd-index-accordion" open><summary class="tsd-accordion-summary tsd-index-summary">
@@ -56,7 +56,7 @@ <h4 class="tsd-parameters-title">Parameters</h4>
 <h5><code class="tsd-tag ts-flagOptional">Optional</code> key: <span class="tsd-signature-type">string</span></h5></li></ul></div>
 <h4 class="tsd-returns-title">Returns <a href="FPUser.html" class="tsd-signature-type" data-tsd-kind="Class">FPUser</a></h4><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/FeatureProbe/client-sdk-miniprogram/blob/ca790cf/WeChat/FPUser.ts#L5">WeChat/FPUser.ts:5</a></li></ul></aside></li></ul></section></section>
+<li>Defined in <a href="https://github.com/panchongyang/client-sdk-miniprogram/blob/af52332/WeChat/FPUser.ts#L5">WeChat/FPUser.ts:5</a></li></ul></aside></li></ul></section></section>
 <section class="tsd-panel-group tsd-member-group">
 <h2>Properties</h2>
 <section class="tsd-panel tsd-member tsd-kind-property tsd-parent-kind-class tsd-is-private"><a id="attrs" class="tsd-anchor"></a>
@@ -68,12 +68,12 @@ <h4>Type declaration</h4>
 <li class="tsd-parameter-index-signature">
 <h5><span class="tsd-signature-symbol">[</span>key: <span class="tsd-signature-type">string</span><span class="tsd-signature-symbol">]: </span><span class="tsd-signature-type">string</span></h5></li></ul></div><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/FeatureProbe/client-sdk-miniprogram/blob/ca790cf/WeChat/FPUser.ts#L3">WeChat/FPUser.ts:3</a></li></ul></aside></section>
+<li>Defined in <a href="https://github.com/panchongyang/client-sdk-miniprogram/blob/af52332/WeChat/FPUser.ts#L3">WeChat/FPUser.ts:3</a></li></ul></aside></section>
 <section class="tsd-panel tsd-member tsd-kind-property tsd-parent-kind-class tsd-is-private"><a id="key" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><code class="tsd-tag ts-flagPrivate">Private</code> <span>key</span><a href="#key" aria-label="Permalink" class="tsd-anchor-icon"><svg class="icon icon-tabler icon-tabler-link" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"><use href="#icon-anchor-a"></use><use href="#icon-anchor-b"></use><use href="#icon-anchor-c"></use></svg></a></h3>
 <div class="tsd-signature">key<span class="tsd-signature-symbol">:</span> <span class="tsd-signature-type">string</span></div><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/FeatureProbe/client-sdk-miniprogram/blob/ca790cf/WeChat/FPUser.ts#L2">WeChat/FPUser.ts:2</a></li></ul></aside></section></section>
+<li>Defined in <a href="https://github.com/panchongyang/client-sdk-miniprogram/blob/af52332/WeChat/FPUser.ts#L2">WeChat/FPUser.ts:2</a></li></ul></aside></section></section>
 <section class="tsd-panel-group tsd-member-group">
 <h2>Methods</h2>
 <section class="tsd-panel tsd-member tsd-kind-method tsd-parent-kind-class"><a id="extendAttrs" class="tsd-anchor"></a>
@@ -91,7 +91,7 @@ <h5>attrs: <span class="tsd-signature-symbol">{ </span><br/><span>    </span
 <h5><span class="tsd-signature-symbol">[</span>key: <span class="tsd-signature-type">string</span><span class="tsd-signature-symbol">]: </span><span class="tsd-signature-type">string</span></h5></li></ul></li></ul></div>
 <h4 class="tsd-returns-title">Returns <a href="FPUser.html" class="tsd-signature-type" data-tsd-kind="Class">FPUser</a></h4><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/FeatureProbe/client-sdk-miniprogram/blob/ca790cf/WeChat/FPUser.ts#L23">WeChat/FPUser.ts:23</a></li></ul></aside></li></ul></section>
+<li>Defined in <a href="https://github.com/panchongyang/client-sdk-miniprogram/blob/af52332/WeChat/FPUser.ts#L23">WeChat/FPUser.ts:23</a></li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member tsd-kind-method tsd-parent-kind-class"><a id="get" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><span>get</span><a href="#get" aria-label="Permalink" class="tsd-anchor-icon"><svg class="icon icon-tabler icon-tabler-link" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"><use href="#icon-anchor-a"></use><use href="#icon-anchor-b"></use><use href="#icon-anchor-c"></use></svg></a></h3>
 <ul class="tsd-signatures tsd-kind-method tsd-parent-kind-class">
@@ -104,7 +104,7 @@ <h4 class="tsd-parameters-title">Parameters</h4>
 <h5>attrName: <span class="tsd-signature-type">string</span></h5></li></ul></div>
 <h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">undefined</span><span class="tsd-signature-symbol"> | </span><span class="tsd-signature-type">string</span></h4><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/FeatureProbe/client-sdk-miniprogram/blob/ca790cf/WeChat/FPUser.ts#L30">WeChat/FPUser.ts:30</a></li></ul></aside></li></ul></section>
+<li>Defined in <a href="https://github.com/panchongyang/client-sdk-miniprogram/blob/af52332/WeChat/FPUser.ts#L30">WeChat/FPUser.ts:30</a></li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member tsd-kind-method tsd-parent-kind-class"><a id="getAttrs" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><span>get<wbr/>Attrs</span><a href="#getAttrs" aria-label="Permalink" class="tsd-anchor-icon"><svg class="icon icon-tabler icon-tabler-link" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"><use href="#icon-anchor-a"></use><use href="#icon-anchor-b"></use><use href="#icon-anchor-c"></use></svg></a></h3>
 <ul class="tsd-signatures tsd-kind-method tsd-parent-kind-class">
@@ -115,15 +115,15 @@ <h4 class="tsd-returns-title">Returns <span class="tsd-signature-symbol">{ </spa
 <li class="tsd-parameter-index-signature">
 <h5><span class="tsd-signature-symbol">[</span>key: <span class="tsd-signature-type">string</span><span class="tsd-signature-symbol">]: </span><span class="tsd-signature-type">string</span></h5></li></ul><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/FeatureProbe/client-sdk-miniprogram/blob/ca790cf/WeChat/FPUser.ts#L19">WeChat/FPUser.ts:19</a></li></ul></aside></li></ul></section>
+<li>Defined in <a href="https://github.com/panchongyang/client-sdk-miniprogram/blob/af52332/WeChat/FPUser.ts#L19">WeChat/FPUser.ts:19</a></li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member tsd-kind-method tsd-parent-kind-class"><a id="getKey" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><span>get<wbr/>Key</span><a href="#getKey" aria-label="Permalink" class="tsd-anchor-icon"><svg class="icon icon-tabler icon-tabler-link" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"><use href="#icon-anchor-a"></use><use href="#icon-anchor-b"></use><use href="#icon-anchor-c"></use></svg></a></h3>
 <ul class="tsd-signatures tsd-kind-method tsd-parent-kind-class">
 <li class="tsd-signature tsd-anchor-link" id="getKey.getKey-1">get<wbr/>Key<span class="tsd-signature-symbol">(</span><span class="tsd-signature-symbol">)</span><span class="tsd-signature-symbol">: </span><span class="tsd-signature-type">string</span><a href="#getKey.getKey-1" aria-label="Permalink" class="tsd-anchor-icon"><svg class="icon icon-tabler icon-tabler-link" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"><use href="#icon-anchor-a"></use><use href="#icon-anchor-b"></use><use href="#icon-anchor-c"></use></svg></a></li>
 <li class="tsd-description">
 <h4 class="tsd-returns-title">Returns <span class="tsd-signature-type">string</span></h4><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/FeatureProbe/client-sdk-miniprogram/blob/ca790cf/WeChat/FPUser.ts#L15">WeChat/FPUser.ts:15</a></li></ul></aside></li></ul></section>
+<li>Defined in <a href="https://github.com/panchongyang/client-sdk-miniprogram/blob/af52332/WeChat/FPUser.ts#L15">WeChat/FPUser.ts:15</a></li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member tsd-kind-method tsd-parent-kind-class"><a id="stableRollout" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><span>stable<wbr/>Rollout</span><a href="#stableRollout" aria-label="Permalink" class="tsd-anchor-icon"><svg class="icon icon-tabler icon-tabler-link" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"><use href="#icon-anchor-a"></use><use href="#icon-anchor-b"></use><use href="#icon-anchor-c"></use></svg></a></h3>
 <ul class="tsd-signatures tsd-kind-method tsd-parent-kind-class">
@@ -136,7 +136,7 @@ <h4 class="tsd-parameters-title">Parameters</h4>
 <h5>key: <span class="tsd-signature-type">string</span></h5></li></ul></div>
 <h4 class="tsd-returns-title">Returns <a href="FPUser.html" class="tsd-signature-type" data-tsd-kind="Class">FPUser</a></h4><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/FeatureProbe/client-sdk-miniprogram/blob/ca790cf/WeChat/FPUser.ts#L34">WeChat/FPUser.ts:34</a></li></ul></aside></li></ul></section>
+<li>Defined in <a href="https://github.com/panchongyang/client-sdk-miniprogram/blob/af52332/WeChat/FPUser.ts#L34">WeChat/FPUser.ts:34</a></li></ul></aside></li></ul></section>
 <section class="tsd-panel tsd-member tsd-kind-method tsd-parent-kind-class"><a id="with" class="tsd-anchor"></a>
 <h3 class="tsd-anchor-link"><span>with</span><a href="#with" aria-label="Permalink" class="tsd-anchor-icon"><svg class="icon icon-tabler icon-tabler-link" viewBox="0 0 24 24" stroke-width="2" stroke="currentColor" fill="none" stroke-linecap="round" stroke-linejoin="round"><use href="#icon-anchor-a"></use><use href="#icon-anchor-b"></use><use href="#icon-anchor-c"></use></svg></a></h3>
 <ul class="tsd-signatures tsd-kind-method tsd-parent-kind-class">
@@ -151,7 +151,7 @@ <h5>attrName: <span class="tsd-signature-type">string</span></h5></li>
 <h5>attrValue: <span class="tsd-signature-type">string</span></h5></li></ul></div>
 <h4 class="tsd-returns-title">Returns <a href="FPUser.html" class="tsd-signature-type" data-tsd-kind="Class">FPUser</a></h4><aside class="tsd-sources">
 <ul>
-<li>Defined in <a href="https://github.com/FeatureProbe/client-sdk-miniprogram/blob/ca790cf/WeChat/FPUser.ts#L10">WeChat/FPUser.ts:10</a></li></ul></aside></li></ul></section></section></div>
+<li>Defined in <a href="https://github.com/panchongyang/client-sdk-miniprogram/blob/af52332/WeChat/FPUser.ts#L10">WeChat/FPUser.ts:10</a></li></ul></aside></li></ul></section></section></div>
 <div class="col-4 col-menu menu-sticky-wrap menu-highlight">
 <div class="tsd-navigation settings">
 <details class="tsd-index-accordion"><summary class="tsd-accordion-summary">