fixed after hvlad review

Author: sim1984

src/jrd/RecordSourceNodes.cpp

@@ -4444,7 +4444,7 @@ dsql_fld* GenSeriesFunctionSourceNode::makeField(DsqlCompilerScratch* dsqlScratc
 		{
 			ERRD_post(Arg::Gds(isc_sqlerr) << Arg::Num(-104) << Arg::Gds(isc_dsql_command_err)
 										   << Arg::Gds(isc_dsql_table_value_many_columns)
-										   << Arg::Str(GenSeriesFunctionSourceNode::FUNC_NAME)
+										   << Arg::Str(getName())
 										   << Arg::Num(1) << Arg::Num(dsqlNameColumns.getCount()));
 		}
 

src/jrd/RecordSourceNodes.h

@@ -1093,7 +1093,7 @@ class GenSeriesFunctionSourceNode : public TableValueFunctionSourceNode
 
 	static constexpr char const* FUNC_NAME = "GENERATE_SERIES";
 
-	const char* getName() const override
+	const char* getName() const final
 	{
 		return FUNC_NAME;
 	}

src/jrd/recsrc/TableValueFunctionScan.cpp

@@ -492,24 +492,20 @@ bool GenSeriesFunctionScan::nextBuffer(thread_db* tdbb) const
 	const auto request = tdbb->getRequest();
 	const auto impure = request->getImpure<Impure>(m_impure);
 
-	auto setIntToRecord = [&](SINT64 i)
+	impure->m_result += impure->m_step;
+
+	if (((impure->m_step > 0) && (impure->m_result <= impure->m_finish)) ||
+        ((impure->m_step < 0) && (impure->m_result >= impure->m_finish)))
 	{
 		Record* const record = request->req_rpb[m_stream].rpb_record;
 
 		auto toDesc = m_format->fmt_desc.begin();
 
 		dsc fromDesc;
-		fromDesc.makeInt64(impure->m_scale, &i);
+		fromDesc.makeInt64(impure->m_scale, &impure->m_result);
 		assignParameter(tdbb, &fromDesc, toDesc, 0, record);
 		impure->m_recordExists = true;
-	};
 
-	impure->m_result += impure->m_step;
-
-	if (((impure->m_step > 0) && (impure->m_result <= impure->m_finish)) ||
-        ((impure->m_step < 0) && (impure->m_result >= impure->m_finish)))
-	{
-		setIntToRecord(impure->m_result);
 		return true;
 	}