BadFunctions/Backticks: error message line precision

A backtick-shell command can be spread out over several lines.

This minor change make it so the error/warning will be reported on the line containing the offending variable, not the line containing the open-backtick, as these may not be the same.

Author: jrfnl

Security/Sniffs/BadFunctions/BackticksSniff.php

@@ -37,9 +37,9 @@ public function process(File $phpcsFile, $stackPtr) {
 		while (($s = $phpcsFile->findNext(T_VARIABLE, ($s + 1), $closer)) !== false) {
 			$msg = 'System execution with backticks detected with dynamic parameter';
 			if ($utils::is_token_user_input($tokens[$s])) {
-				$phpcsFile->addError($msg . ' directly from user input', $stackPtr, 'ErrSystemExec');
+				$phpcsFile->addError($msg . ' directly from user input', $s, 'ErrSystemExec');
 			} else {
-				$phpcsFile->addWarning($msg, $stackPtr, 'WarnSystemExec');
+				$phpcsFile->addWarning($msg, $s, 'WarnSystemExec');
 			}
 		}
 

Security/Tests/BadFunctions/BackticksUnitTest.inc

@@ -12,6 +12,10 @@ $output = `git blame --date=short "$filename"`; // Warning.
 
 $output = `git blame --date=$_POST['key'] "$filename"`; // Warning + error.
 
+$output = `git blame
+	--date=$_POST['key'] // Error.
+	"$filename"`; // Warning.
+
 // Incomplete command. Ignore.
 // Intentional parse error. This should be the last test in the file.
 $output = `ls

Security/Tests/BadFunctions/BackticksUnitTest.php

@@ -27,6 +27,7 @@ public function getErrorList($testFile = '')
 				return [
 					9  => 1,
 					13 => 1,
+					16 => 1,
 				];
 
 			case 'BackticksUnitTest.Drupal7.inc':
@@ -72,6 +73,7 @@ public function getWarningList($testFile = '')
 					8  => 1,
 					11 => 1,
 					13 => 1,
+					17 => 1,
 				];
 
 			case 'BackticksUnitTest.Drupal7.inc':