Skip to content

[Bug] Recommended by Pocket has vanilla/non-matching styling  #375

@dominichayesferen

Description

@dominichayesferen

Attention!

  • I undertand that Floorp is NOT supported on Windows 7/8.1 or lower.

Describe the bug

The 'Recommended by Pocket' section of New Tab has vanilla Firefox's styling, which makes it look kinda awful against new tab page backgrounds.

To Reproduce

  1. Be in a region where Recommended by Pocket exists, such as Britain
  2. Start a new Floorp profile

Expected behavior

It'll use white header text, and the posts themselves will look way more consistent with the rest of the NTP.

Screenshots

Screenshot_20230814_164813

OS Info

Feren OS 2023.04

Floorp Version

11.1.2 (Flathub)

Additional context

In case you don't have this in Japan, here's the style classes:

  • 'Recommended by Pocket': .section-title, chrome://activity-stream/content/css/activity-stream.css:2273
  • 'Learn more': .learn-more-link a, chrome://activity-stream/content/css/activity-stream.css:2704
  • Cards on this section: .ds-card-grid .ds-card, chrome://activity-stream/content/css/activity-stream.css:2712, chrome://activity-stream/content/css/activity-stream.css:2721
  • Cards' titles: .ds-card header
  • Cards' text: .ds-card p
  • Cards' websites/read-times: .ds-card .meta .source

about:config values:

  • Show sponsored stories: browser.newtabpage.activity-stream.showSponsored
  • Recommended by Pocket (enables the section this issue is about, on by default in available regions): browser.newtabpage.activity-stream.feeds.section.topstories
  • Show sponsored sites in top sites section: browser.newtabpage.activity-stream.showSponsoredTopSites

Style-values of settings in New Tab Page's settings:

  • The whole 'Recommended by Pocket' option: #pocket-section
  • Sponsored Top Sites checkbox: #sponsored-shortcuts and data-l10n-id="newtab-custom-sponsored-sites"

Same settings but in about:preferences:

  • 'Recommended by Pocket': data-subcategory="topstories"
  • Sponsored Top Sites checkbox: data-l10n-id="home-prefs-shortcuts-by-option-sponsored"

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions