junit Test output?

[kknapp1]

Just started using the tool (love it!) and will be using it in our CI pipeline. I'd like to output the test results in junit format (like the Salesforce Scanner tool does). Is anyone else doing that @RubenHalman?

If not junit, how are you using the tool in CI pipelines to give feedback on PR's?
Is anyone aware of another plugin or tool that will convert the json output of lightning-flow-scanner into junit XML (before I go searching)?

[kknapp1]

thx for the response @RubenHalman. +1 for including in Code Analyzer - I'll lend my vote to that for sure.

I'll start looking/building a mapping of the json output to junit test results. (i'm not super-familiar w/typescript but maybe even submit a PR if i get something useful to work.)

is the json output generated in this sfdx plugin, or is it generated in the core module? i.e. where would you expect that enhancement to go?

[RubenHalman]

thx for the response @RubenHalman. +1 for including in Code Analyzer - I'll lend my vote to that for sure.

I'll start looking/building a mapping of the json output to junit test results. (i'm not super-familiar w/typescript but maybe even submit a PR if i get something useful to work.)

is the json output generated in this sfdx plugin, or is it generated in the core module? i.e. where would you expect that enhancement to go?

Thanks, I think @junners or @nvuillam will likely know more on this topic as I do and have a better perspective. My guess would be in the sfdx plugin itself but maybe I am wrong.

[junners]

thx for the response @RubenHalman. +1 for including in Code Analyzer - I'll lend my vote to that for sure.
I'll start looking/building a mapping of the json output to junit test results. (i'm not super-familiar w/typescript but maybe even submit a PR if i get something useful to work.)
is the json output generated in this sfdx plugin, or is it generated in the core module? i.e. where would you expect that enhancement to go?

Thanks, I think @junners or @nvuillam will likely know more on this topic as I do and have a better perspective. My guess would be in the sfdx plugin itself but maybe I am wrong.

Hey @kknapp1 you're absolutely right, it would be in the sfdx module here @RubenHalman's just being modest, he knows the plugin in & out 💯

We had actually thought about doing this too from a while back. We just didn't know if it would stick haha here's a draft of our proposal

[junners]

Coming to think of it. having to support JUNIT would be a good adoption indicator, majority of the git providers know how to read junit results

[nvuillam]

I think that if a format should be implemented as output... SARIF is the good choice as it is the standard for all SAST Tools :)

It can be facilitated using this library :) https://www.npmjs.com/package/node-sarif-builder

[RubenHalman]

Hi @kknapp1, I have read up on this. SARIF and JUnit serve different purposes. It seems that having SARIF output would perhaps make a JUnit implementation easier. @nvuillam 's suggestion is great for the core module, but JUnit should be implemented in the CLI (Where you have access to parse files),

[kknapp1]

That makes sense, @RubenHalman. My suggestion is flexible. My ultimate goal is just to get test output that can easily be displayed in Azure DevOps test results. So, any direction and guidance would be helpful for me.

Obviously, this isn't as high a priority for my team as it once was, but it would still be valuable (or the SARIF output instead). I'll keep an eye on this discussion and other enhancements and may get back to it.

Thanks!

[RubenHalman]

@kknapp1 The core module now exposes a method to generate the SARIF output. This means the Salesforce CLI plugin can output SARIF directly to stdout, and it can stop CI builds (like in GitHub Actions).

Please see #183 for a potential ADO template