Skip to content

Commit 5dd8f0b

Browse files
committed
Bug fixes and performance improvements
1 parent fa87bf8 commit 5dd8f0b

File tree

8 files changed

+23
-12
lines changed

8 files changed

+23
-12
lines changed

Example/RaveSDK.xcodeproj/project.pbxproj

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,7 @@
211211
TargetAttributes = {
212212
607FACCF1AFB9204008FA782 = {
213213
CreatedOnToolsVersion = 6.3.1;
214+
DevelopmentTeam = NSPMGSMKS7;
214215
LastSwiftMigration = 0900;
215216
};
216217
607FACE41AFB9204008FA782 = {
@@ -482,12 +483,13 @@
482483
baseConfigurationReference = A2A54C44696D217D69C4769A /* Pods-RaveSDK_Example.debug.xcconfig */;
483484
buildSettings = {
484485
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
486+
DEVELOPMENT_TEAM = NSPMGSMKS7;
485487
INFOPLIST_FILE = RaveSDK/Info.plist;
486488
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
487489
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
488490
MARKETING_VERSION = 2.3.1;
489491
MODULE_NAME = ExampleApp;
490-
PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.demo.$(PRODUCT_NAME:rfc1034identifier)";
492+
PRODUCT_BUNDLE_IDENTIFIER = com.;
491493
PRODUCT_NAME = "$(TARGET_NAME)";
492494
SWIFT_SWIFT3_OBJC_INFERENCE = Default;
493495
SWIFT_VERSION = 4.0;
@@ -500,12 +502,13 @@
500502
baseConfigurationReference = DEB5BD93E69BD4BFCE599006 /* Pods-RaveSDK_Example.release.xcconfig */;
501503
buildSettings = {
502504
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
505+
DEVELOPMENT_TEAM = NSPMGSMKS7;
503506
INFOPLIST_FILE = RaveSDK/Info.plist;
504507
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
505508
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
506509
MARKETING_VERSION = 2.3.1;
507510
MODULE_NAME = ExampleApp;
508-
PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.demo.$(PRODUCT_NAME:rfc1034identifier)";
511+
PRODUCT_BUNDLE_IDENTIFIER = com.;
509512
PRODUCT_NAME = "$(TARGET_NAME)";
510513
SWIFT_SWIFT3_OBJC_INFERENCE = Default;
511514
SWIFT_VERSION = 4.0;

Example/RaveSDK/Info.plist

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
<dict>
55
<key>CFBundleDevelopmentRegion</key>
66
<string>en</string>
7+
<key>CFBundleDisplayName</key>
8+
<string>RaveSDK</string>
79
<key>CFBundleExecutable</key>
810
<string>$(EXECUTABLE_NAME)</string>
911
<key>CFBundleIdentifier</key>

Example/RaveSDK/ViewController.swift

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@ class ViewController: UIViewController ,RavePayProtocol {
2323
}
2424

2525
@IBAction func showAction(_ sender: Any){
26-
let config = RaveConfig.sharedConfig()
26+
27+
let config = RaveConfig.sharedConfig()
2728
config.paymentOptionsToExclude = []
2829
config.currencyCode = "NGN" // This is the specified currency to charge in.
2930
config.email = "[USER'S EMAIL]" // This is the email address of the customer
@@ -32,7 +33,7 @@ class ViewController: UIViewController ,RavePayProtocol {
3233
config.transcationRef = "[TRANSACTION REF]" // This is a unique reference, unique to the particular transaction being carried out. It is generated when it is not provided by the merchant for every transaction.
3334
config.firstName = "[USER'S FIRST NAME]" // This is the customers first name.
3435
config.lastName = "[USER'S SECOND NAME]" //This is the customers last name.
35-
config.meta = [["metaname":"sdk", "metavalue":"ios"]] //This is used to include additional payment information
36+
config.meta = [["metaname":"iOS-SDK-v2", "metavalue": MetaValueDetails(paymentDetails: "", recieptId: "")]] //This is used to include additional payment information
3637
config.narration = "simplifying payments for endless possibilities"
3738
config.publicKey = "[PUB_KEY]" //Public key
3839
config.encryptionKey = "[ENCRYPTION_KEY]" //Encryption key
@@ -42,10 +43,8 @@ class ViewController: UIViewController ,RavePayProtocol {
4243
controller.amount = "[AMOUNT]" // This is the amount to be charged.
4344
controller.delegate = self
4445
self.present(nav, animated: true)
45-
46-
}
47-
48-
46+
47+
}
4948

5049

5150
override func viewDidLoad() {
@@ -60,3 +59,8 @@ class ViewController: UIViewController ,RavePayProtocol {
6059

6160
}
6261

62+
63+
struct MetaValueDetails {
64+
var paymentDetails:String
65+
var recieptId:String
66+
}

RaveSDK.podspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
Pod::Spec.new do |s|
1010
s.name = 'RaveSDK'
11-
s.version = '2.3.1'
11+
s.version = '2.3.2'
1212
s.summary = 'RaveSDK'
1313

1414
# This description is used to generate tags and improve search results.

RaveSDK/Classes/Config/RaveConfig.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public class RaveConfig {
2727
public var currencyCode:String = "NGN"
2828
public var narration:String?
2929
public var isPreAuth:Bool = false
30-
public var meta:[[String:String]]?
30+
public var meta:[[String:Any]]?
3131
public var subAccounts:[SubAccount]?
3232
public var whiteListedBanksOnly:[String]?
3333
public var paymentOptionsToExclude:[PaymentOption] = []

RaveSDK/Classes/UI/OTPView.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ class OTPView: UIView {
1717
label.textAlignment = .center
1818
label.numberOfLines = 0
1919
label.font = UIFont.systemFont(ofSize: 17, weight: .regular)
20+
label.textColor = .black
2021
return label
2122
}()
2223

RaveSDK/Classes/UI/SelectBankAccountView.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ class SelectBankAccountView: UIView {
1717
label.textAlignment = .center
1818
label.numberOfLines = 0
1919
label.font = UIFont.systemFont(ofSize: 17, weight: .regular)
20+
label.textColor = .black
2021
return label
2122
}()
2223

RaveSDK/Classes/Utils/RaveConstants.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class RaveConstants: NSObject {
2525

2626
}
2727

28-
static let bankStyle = [(code:"044",color:"#143f89",image:"rave_access2"),
28+
static let bankStyle = [
2929
(code:"101",color:"#ffffff",image:"rave_providus2"),
3030
(code:"232",color:"#ad1620",image:"rave_sterling2"),
3131
(code:"057",color:"#ed3237",image:"rave_zenith2"),
@@ -66,7 +66,7 @@ class RaveConstants: NSObject {
6666
"""),
6767
("AIRTEL","","")]
6868

69-
static let zambianNetworks = ["MTN"]
69+
static let zambianNetworks = ["AIRTEL","MTN","ZAMTEL"]
7070

7171
class func isConnectedToInternet() ->Bool {
7272
return NetworkReachabilityManager()!.isReachable

0 commit comments

Comments
 (0)