fix(davinci-client): improve fido module error handling

Author: ancheetah

.changeset/full-bikes-boil.md

@@ -0,0 +1,5 @@
+---
+'@forgerock/davinci-client': patch
+---
+
+Improve FIDO module error handling when no options

e2e/davinci-suites/src/fido.test.ts

@@ -87,7 +87,9 @@ test.describe('FIDO/WebAuthn Tests', () => {
     await expect(page.getByText('FIDO2 Test Form')).toBeVisible();
   });
 
-  test('Register and authenticate with usernameless', async ({ page }) => {
+  // Note: This test is currently not working due to a DaVinci issue where the authentication options
+  // are not included in the response.
+  test.skip('Register and authenticate with usernameless', async ({ page }) => {
     const { navigate } = asyncEvents(page);
 
     await navigate(

packages/davinci-client/src/lib/fido/fido.ts

@@ -55,6 +55,14 @@ export function fido(): FidoClient {
     register: async function register(
       options: FidoRegistrationOptions,
     ): Promise<FidoRegistrationInputValue | GenericError> {
+      if (!options) {
+        return {
+          error: 'registration_error',
+          message: 'FIDO registration failed: No options available',
+          type: 'fido_error',
+        } as GenericError;
+      }
+
       const createCredentialµ = Micro.sync(() => transformRegistrationOptions(options)).pipe(
         Micro.flatMap((publicKeyCredentialCreationOptions) =>
           Micro.tryPromise({
@@ -108,6 +116,14 @@ export function fido(): FidoClient {
     authenticate: async function authenticate(
       options: FidoAuthenticationOptions,
     ): Promise<FidoAuthenticationInputValue | GenericError> {
+      if (!options) {
+        return {
+          error: 'authentication_error',
+          message: 'FIDO authentication failed: No options available',
+          type: 'fido_error',
+        } as GenericError;
+      }
+
       const getAssertionµ = Micro.sync(() => transformAuthenticationOptions(options)).pipe(
         Micro.flatMap((publicKeyCredentialRequestOptions) =>
           Micro.tryPromise({