Skip to content

React 19 - defaultProps removed breaks stuff like FullScreen #1350

@AndyOGo

Description

@AndyOGo

Prerequisites

Describe Your Environment

What version of Spectacle are you using? (can be found by running npm list --depth 0 spectacle)

spectacle@10.2.0

What version of React are you using? (can be found by running npm list --depth 0 react)

react@19.1.0

What browser are you using? (e.g., Chrome 105.0.5195.102, Safari 16.0)
Edge

What platform are you on? (e.g., Windows, macOS, iOS, Android)
Windows

Describe the Problem

React 19 removed defaultProps and other APIs.
https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops

Expected behavior: [What you expect to happen] <FullScreen> should have a default size

Actual behavior: [What actually happens] <FullScreen> has no default size

Additional Information

Affected code
https://github.com/search?q=repo%3AFormidableLabs%2Fspectacle%20defaultProps%20&type=code

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions