Skip to content

Commit cc54c56

Browse files
committed
GHA ifs need to include success, or a previous step failure will not stop the run
1 parent 81fca40 commit cc54c56

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

.github/workflows/deploy.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -54,28 +54,28 @@ jobs:
5454
go-version: '1.20'
5555

5656
- name: Compile
57-
if: inputs.command != 'release'
57+
if: success() && inputs.command != 'release'
5858
run: sb compile
5959

6060
- name: Copy our kickstart file over so it gets picked up
61-
if: inputs.command != 'release'
61+
if: success() && inputs.command != 'release'
6262
run: |
6363
mkdir faDockerComposeFilePath
6464
cp -r .github/kickstart faDockerComposeFilePath
6565
cp .github/kickstart/kickstart.json faDockerComposeFilePath/kickstart/k2.json
6666
cp .github/kickstart/kickstart.json .github/kickstart/k2.json
6767
6868
- name: Start FusionAuth
69-
if: inputs.command != 'release'
69+
if: success() && inputs.command != 'release'
7070
uses: fusionauth/fusionauth-github-action@v1
7171
with:
7272
FUSIONAUTH_APP_KICKSTART_FILENAME: k2.json
7373
FUSIONAUTH_APP_KICKSTART_DIRECTORY_PATH: .github/kickstart
7474

7575
- name: Run tests
76-
if: inputs.command != 'release'
76+
if: success() && inputs.command != 'release'
7777
run: sleep 30 && sb test
7878

7979
- name: release to svn
80-
if: inputs.command == 'release'
80+
if: success() && inputs.command == 'release'
8181
run: sb release

0 commit comments

Comments
 (0)