Skip to content

Commit 396ed11

Browse files
committed
last fixes
1 parent 43dd2d1 commit 396ed11

File tree

5 files changed

+23
-24
lines changed

5 files changed

+23
-24
lines changed

geos-mesh/src/geos/mesh/processing/MergeBlockEnhanced.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -110,18 +110,17 @@ def applyFilter( self: Self ) -> None:
110110
111111
Returns:
112112
bool: True if the blocks were successfully merged, False otherwise.
113+
114+
Raises:
115+
VTKError (geos.utils.Errors) : error captured if any from the VTK log
113116
"""
114117
self.logger.info( f"Applying filter { self.logger.name }." )
115118

116119
outputMesh: vtkUnstructuredGrid
117-
try:
118-
outputMesh = mergeBlocks( self.inputMesh, keepPartialAttributes=True, logger=self.logger )
119-
except ( VTKError ):
120-
self.logger.info( f"The filter {self.logger.name} failed." )
121-
raise
122-
else:
123-
self.outputMesh = outputMesh
124-
self.logger.info( f"The filter {self.logger.name} succeeded." )
120+
outputMesh = mergeBlocks( self.inputMesh, keepPartialAttributes=True, logger=self.logger )
121+
self.logger.info( f"The filter {self.logger.name} failed." )
122+
self.outputMesh = outputMesh
123+
self.logger.info( f"The filter {self.logger.name} succeeded." )
125124

126125

127126
def getOutput( self: Self ) -> vtkUnstructuredGrid:

geos-mesh/src/geos/mesh/utils/multiblockModifiers.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
# SPDX-FileCopyrightText: Copyright 2023-2024 TotalEnergies.
33
# SPDX-FileContributor: Martin Lemay, Paloma Martinez
44
from typing import Union
5+
import logging
6+
# import re
57

68
from vtkmodules.vtkCommonDataModel import ( vtkCompositeDataSet, vtkDataObjectTreeIterator, vtkMultiBlockDataSet,
79
vtkUnstructuredGrid, vtkDataSet )
@@ -16,7 +18,8 @@
1618
from vtkmodules.vtkFiltersCore import vtkAppendDataSets
1719

1820
from geos.mesh.utils.arrayModifiers import fillAllPartialAttributes
19-
from geos.utils.Logger import ( getLogger, Logger, VTKCaptureLog, RegexExceptionFilter )
21+
from geos.utils.Errors import VTKError
22+
from geos.utils.Logger import ( getLogger, Logger, VTKCaptureLog, RegexExceptionFilter)
2023

2124
__doc__ = """Contains a method to merge blocks of a VTK multiblock dataset."""
2225

@@ -52,7 +55,8 @@ def mergeBlocks(
5255
logger: Logger = getLogger( "mergeBlocks", True )
5356

5457
vtkLogger.SetStderrVerbosity(vtkLogger.VERBOSITY_TRACE)
55-
logger.addFilter(RegexExceptionFilter())
58+
logger.addFilter(RegexExceptionFilter()) # will raise VTKError if captured VTK Error
59+
logger.setLevel(logging.DEBUG)
5660

5761
# Fill the partial attributes with default values to keep them during the merge.
5862
if keepPartialAttributes and not fillAllPartialAttributes( inputMesh, logger ):
@@ -87,7 +91,7 @@ def mergeBlocks(
8791
captured_log.seek(0) #be kind let's just rewind
8892
captured = captured_log.read().decode()
8993

90-
logger.error(captured.strip())
94+
logger.debug(captured.strip())
9195
outputMesh: vtkUnstructuredGrid = af.GetOutputDataObject( 0 )
9296

9397
return outputMesh

geos-posp/src/PVplugins/PVMohrCirclePlot.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -804,11 +804,7 @@ def createMohrCirclesAtTimeStep(
804804
list[MohrCircle]: list of MohrCircles for the current time step.
805805
"""
806806
# get mesh and merge if needed
807-
try:
808-
meshMerged: vtkUnstructuredGrid = mergeBlocks( mesh )
809-
except (VTKError):
810-
raise
811-
807+
meshMerged: vtkUnstructuredGrid = mergeBlocks( mesh )
812808
# assert meshMerged is not None, "Input data is undefined"
813809

814810
stressArray: npt.NDArray[ np.float64 ] = getArrayInObject( meshMerged,

geos-posp/src/geos_posp/filters/GeosBlockMerge.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -366,12 +366,8 @@ def mergeChildBlocks( self: Self, compositeBlock: vtkMultiBlockDataSet ) -> vtkU
366366
self.m_logger.warning( "Some partial attributes may not have been propagated to the whole mesh." )
367367

368368
# merge blocks
369-
try:
370-
mergedBlocks = mergeBlocks( compositeBlock )
371-
except (VTKError):
372-
raise
373-
else:
374-
return mergedBlocks
369+
mergedBlocks = mergeBlocks( compositeBlock )
370+
return mergedBlocks
375371

376372
def convertFaultsToSurfaces( self: Self ) -> bool:
377373
"""Convert blocks corresponding to faults to surface.

geos-utils/src/geos/utils/Logger.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,13 @@ def __init__(self):
5454

5555
def filter(self, record : logging.LogRecord):
5656
"""
57-
Filter VTK Error from stdErr
57+
Filter VTK Error from stdErr.
5858
5959
Args:
6060
record(loggging.LogRecord)
61+
62+
Raises:
63+
VTKError(geos.utils.Error) if a pattern symbol is caught in the stderr.
6164
"""
6265
message = record.getMessage()
6366
if self.regex.search(message):
@@ -82,7 +85,8 @@ def VTKCaptureLog()->Generator[Any,Any,Any]:
8285
# print(err)
8386

8487
# Save original stderr file descriptor
85-
original_stderr_fd = sys.stderr.fileno()
88+
# original_stderr_fd = sys.stderr.fileno()
89+
original_stderr_fd = 2
8690
saved_stderr_fd = os.dup(original_stderr_fd)
8791

8892
# Create a temporary file to capture stderr

0 commit comments

Comments
 (0)