Skip to content

Commit 65a209f

Browse files
committed
some more fixes
1 parent 3c2d466 commit 65a209f

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

.github/workflows/python-package.yml

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ jobs:
3636
# build and test the standalone CI
3737
build:
3838
runs-on: ubuntu-latest
39+
needs: [semantic_pull_request]
3940
if: ${{ !github.event.pull_request.draft }}
4041
strategy:
4142
fail-fast: false
@@ -104,6 +105,7 @@ jobs:
104105
# check if GEOS has label for testing GEOS integration
105106
check_integration_label:
106107
runs-on: ubuntu-latest
108+
needs: [build]
107109
outputs:
108110
has_geos_integration_label: ${{ steps.set-label.outputs.has_label }}
109111
steps:
@@ -135,7 +137,6 @@ jobs:
135137
uses: actions/checkout@v4
136138
with:
137139
fetch-depth: 0 # Fetch all history to compare with base branch
138-
139140
- name: Check if GEOS integration is required
140141
id: check_changes
141142
run: |
@@ -240,16 +241,16 @@ jobs:
240241
if: ${{needs.check_geos_integration_required.outputs.geos_integration_required == 'true' }} && ${{ needs.check_integration_label.outputs.has_geos_integration_label == 'true' }}
241242
uses: ./.github/workflows/test_geos_integration.yml
242243

243-
# warn if not used
244-
geos_integration_test_fail:
245-
name: GEOS Integration Test
246-
runs-on: ubuntu-latest
247-
needs: [check_geos_integration_required,check_integration_label]
248-
if: ${{needs.check_geos_integration_required.outputs.geos_integration_required == 'true' }} && ${{ needs.check_integration_label.outputs.has_geos_integration_label == 'false' }}
249-
steps:
250-
- name: Send an error is GEOS-integration is required but no flag is detected
251-
id: send_missing_flag_error
252-
run: echo "You need to test for GEOS-integration please add /test-geos-integration/ label and rerun the CI"
244+
# # warn if not used
245+
# geos_integration_test_fail:
246+
# name: GEOS Integration Test
247+
# runs-on: ubuntu-latest
248+
# needs: [check_geos_integration_required,check_integration_label]
249+
# if: ${{needs.check_geos_integration_required.outputs.geos_integration_required == 'true' }} && ${{ needs.check_integration_label.outputs.has_geos_integration_label == 'false' }}
250+
# steps:
251+
# - name: Send an error is GEOS-integration is required but no flag is detected
252+
# id: send_missing_flag_error
253+
# run: echo "You need to test for GEOS-integration please add /test-geos-integration/ label and rerun the CI"
253254

254255
# Final validation - Summarize CI results
255256
final_validation:

0 commit comments

Comments
 (0)