-
Notifications
You must be signed in to change notification settings - Fork 114
Open
Labels
feature requestRequest for a new feature in GalSimRequest for a new feature in GalSimnumericsInvolving details of the numerical algorithms for performing some calculation(s)Involving details of the numerical algorithms for performing some calculation(s)
Description
Hello,
I've discussed with @gbernstein and @rmjarvis about a variation of the present Quintic kernel cooked by Gary & Daniel (@danielgruen) in their 2014 article. I have a github repo where I have sone nbs to reproduce the Figures of their paper (In the repo their is also a note in French to make some communication for local colleagues).
Here is some closeup on the central image and one of the first ghost image to compare Gary & Daniel ("BG") kernel and mine ("JE" standing for Jean-Eric)
and the error functions curves
Now, I would be glad to make a PR with this new kernel. Let me know how to proceed. Thanks.
For instance:
- how is computed/defined "def krange(self)": I have seen code 'galsim/interpolant.py'. But there is also in 'src/interpolant.cpp' some code to define
_umax
with a factor 1/Pi instead a factor 2. - Does USE_TABLES is activated (should be implemented) in the C++ code
- I do not what
void Quintic::checkSampler() const
is doing. - where in th ePython code self._i.getPositiveFlux() and self._i.getNegativeFlux() are defined, I guess in the C++ ?
- I have seen in the C++ code some #ifdef ALT_QUINTIC but I remember that it is not used, right?
- for the PR I will create a QuinticBis class (both in Python and C++), is-it Ok or do you prefer another naming?
- I have seen test_interpolatedimage.py with a section for Quintic interpolant itself L292... and unitIntegral L388... but I may have missed something. Let me know
Metadata
Metadata
Assignees
Labels
feature requestRequest for a new feature in GalSimRequest for a new feature in GalSimnumericsInvolving details of the numerical algorithms for performing some calculation(s)Involving details of the numerical algorithms for performing some calculation(s)