fix many clang-tidy warnings

Author: jube

examples/19-gridmap.cc

@@ -96,7 +96,7 @@ namespace {
     , m_grid_map(gf::GridMap::make_orthogonal(MapSize, CellSize))
     {
       for (auto position : gf::position_range(MapSize)) {
-        switch (Grid[position.y][position.x]) {
+        switch (Grid[position.y][position.x]) { // NOLINT(cppcoreguidelines-pro-bounds-constant-array-index)
           case ' ':
             m_grid_map.set_properties(position, gf::CellProperty::Walkable | gf::CellProperty::Transparent);
             break;
@@ -210,7 +210,7 @@ namespace {
             const auto& mouse_motion_event = event.from<gf::EventType::MouseMoved>();
             auto mouse_position = mouse_motion_event.position;
             auto mouse_location = position_to_world_location(mouse_position);
-            gf::Vec2I position = m_grid_entity.grid().compute_position(mouse_location);
+            const gf::Vec2I position = m_grid_entity.grid().compute_position(mouse_location);
 
             if (position != m_state.light) {
               m_state.light = position;

include/gf2/core/Activities.h

@@ -307,7 +307,7 @@ namespace gf {
       template<typename Tuple, std::size_t... Indices>
       struct ActivityTupleGetters<Tuple, std::index_sequence<Indices...>> {
         using Getter = Activity& (*)(Tuple&);
-        static inline constexpr Getter Table[std::tuple_size_v<Tuple>] = { &activity_tuple_get<Tuple, Indices>... };
+        static constexpr Getter Table[std::tuple_size_v<Tuple>] = { &activity_tuple_get<Tuple, Indices>... };
       };
 
       template<typename Tuple>

include/gf2/core/Array2D.h

@@ -140,7 +140,7 @@ namespace gf {
 
     std::size_t linearize(Vec2I index) const
     {
-      return static_cast<std::size_t>(index.x) + static_cast<std::size_t>(index.y) * static_cast<std::size_t>(m_size.x);
+      return static_cast<std::size_t>(index.x) + (static_cast<std::size_t>(index.y) * static_cast<std::size_t>(m_size.x));
     }
 
     Vec2I m_size;

include/gf2/core/BinaryHeap.h

@@ -156,12 +156,12 @@ namespace gf {
 
     static constexpr size_type left_child_index(size_type index)
     {
-      return 2 * index + 1;
+      return (2 * index) + 1;
     }
 
     static constexpr size_type right_child_index(size_type index)
     {
-      return 2 * index + 2;
+      return (2 * index) + 2;
     }
 
     bool leaf(size_type index) const

include/gf2/core/GridVisibility.h

@@ -90,7 +90,7 @@ namespace gf {
 
       int relative_slope(Vec2I point) const
       {
-        return (far.y - near.y) * (far.x - point.x) - (far.y - point.y) * (far.x - near.x);
+        return ((far.y - near.y) * (far.x - point.x)) - ((far.y - point.y) * (far.x - near.x));
       }
     };
 

include/gf2/core/Mat3.h

@@ -88,8 +88,8 @@ namespace gf {
     const float sin = std::sin(angle);
     // clang-format off
     return {{
-      {  cos,- sin, center.x * (1 - cos) + center.y * sin },
-      {  sin,  cos, center.y * (1 - cos) - center.x * sin },
+      {  cos,- sin, (center.x * (1 - cos)) + (center.y * sin) },
+      {  sin,  cos, (center.y * (1 - cos)) - (center.x * sin) },
       { 0.0f, 0.0f, 1.0f }
     }};
     // clang-format on

include/gf2/core/Math.h

@@ -58,9 +58,15 @@ namespace gf {
     template<typename T>
     constexpr std::enable_if_t<std::is_arithmetic_v<T>, T> clamp(T val, T min, T max)
     {
-      // clang-format off
-      return val < min ? min : (max < val ? max : val);
-      // clang-format on
+      if (val < min) {
+        return min;
+      }
+
+      if (max < val) {
+        return max;
+      }
+
+      return val;
     }
 
   } // namespace details
@@ -126,7 +132,7 @@ namespace gf {
   template<typename T, typename U>
   constexpr T lerp(T lhs, T rhs, U t)
   {
-    return T((U(1) - t) * lhs + t * rhs);
+    return T(((U(1) - t) * lhs) + (t * rhs));
   }
 
   template<typename T>
@@ -168,13 +174,13 @@ namespace gf {
   template<typename T>
   constexpr std::enable_if_t<std::is_integral_v<T>, T> div_floor(T dividend, T divisor)
   {
-    return dividend / divisor - (dividend % divisor != 0) * ((dividend < 0) ^ (divisor < 0));
+    return (dividend / divisor) - ((dividend % divisor != 0) * ((dividend < 0) ^ (divisor < 0)));
   }
 
   template<typename T>
   constexpr std::enable_if_t<std::is_integral_v<T>, T> div_ceil(T dividend, T divisor)
   {
-    return dividend / divisor + (dividend % divisor != 0) * ((dividend > 0) ^ (divisor < 0));
+    return (dividend / divisor) + ((dividend % divisor != 0) * ((dividend > 0) ^ (divisor < 0)));
   }
 
 } // namespace gf

library/core/BinPack.cc

@@ -17,7 +17,7 @@ namespace gf {
   namespace {
     int score_best_area(Vec2I size, RectI rectangle)
     {
-      return rectangle.extent.w * rectangle.extent.h - size.w * size.h;
+      return (rectangle.extent.w * rectangle.extent.h) - (size.w * size.h);
     }
 
     int score_best_short_side(Vec2I size, RectI rectangle)

library/core/Bitmap.cc

@@ -123,7 +123,7 @@ namespace gf {
 
   std::ptrdiff_t Bitmap::offset_from_position(Vec2I position) const
   {
-    return static_cast<std::ptrdiff_t>(position.x) + static_cast<std::ptrdiff_t>(position.y) * static_cast<std::ptrdiff_t>(m_size.w);
+    return static_cast<std::ptrdiff_t>(position.x) + (static_cast<std::ptrdiff_t>(position.y) * static_cast<std::ptrdiff_t>(m_size.w));
   }
 
 }

library/core/Color.cc

@@ -29,7 +29,7 @@ namespace gf {
 
       if ((max - min) > std::numeric_limits<float>::epsilon()) {
         if (max == color.r) {
-          hue = std::fmod(60.0f * (color.g - color.b) / (max - min) + 360.0f, 360.0f);
+          hue = std::fmod((60.0f * (color.g - color.b) / (max - min)) + 360.0f, 360.0f);
         } else if (max == color.g) {
           hue = 60.0f * (color.b - color.r) / (max - min) + 120.0f;
         } else if (max == color.b) {
@@ -39,7 +39,7 @@ namespace gf {
         }
       }
 
-      const float sat = (max < std::numeric_limits<float>::epsilon()) ? 0.0f : (1.0f - min / max);
+      const float sat = (max < std::numeric_limits<float>::epsilon()) ? 0.0f : (1.0f - (min / max));
       const float val = max;
 
       return { hue, sat, val, color.a };
@@ -135,7 +135,7 @@ namespace gf {
 
     float linear_to_srgb(float c)
     {
-      return (c < 0.0031308f) ? 12.92f * c : 1.055f * std::pow(c, 1.f / 2.4f) - 0.055f;
+      return (c < 0.0031308f) ? 12.92f * c : (1.055f * std::pow(c, 1.f / 2.4f)) - 0.055f;
     }
   }