Zauber Cauldrons: Fix Edge-Case Causing Leftover Custom Liquid Display Entities (#941)

* Check for Water instead of Not-Powdered-Snow

* Call Destroy Function upon Invalid Recipe

Author: Bloo-dev

gm4_zauber_cauldrons/data/gm4_zauber_cauldrons/functions/recipes/potions/invalid_recipe.mcfunction

@@ -8,4 +8,6 @@ execute align xyz run kill @e[type=item,dx=0,dy=0,dz=0]
 #visuals
 scoreboard players reset $expected_item_amount gm4_zc_fullness
 summon tnt
-kill @s
+
+# kill marker and related entities
+function gm4_zauber_cauldrons:cauldron/structure/destroy

gm4_zauber_cauldrons/data/gm4_zauber_cauldrons/functions/recipes/potions/lingering/check_liquid.mcfunction

@@ -6,5 +6,5 @@
 # the select_effect function is generated via beet from templates
 execute if score $has_powder_snow gm4_zc_data matches 1.. run function gm4_zauber_cauldrons:recipes/potions/lingering/select_effect
 
-# no powder snow
-execute unless score $has_powder_snow gm4_zc_data matches 1.. run function gm4_zauber_cauldrons:recipes/potions/invalid_recipe
+# water used instead of powder snow
+execute if score $has_water gm4_zc_data matches 1.. run function gm4_zauber_cauldrons:recipes/potions/invalid_recipe

gm4_zauber_cauldrons/data/gm4_zauber_cauldrons/functions/recipes/potions/splash/check_liquid.mcfunction

@@ -6,5 +6,5 @@
 # the select_effect function is generated via beet from templates
 execute if score $has_powder_snow gm4_zc_data matches 1.. run function gm4_zauber_cauldrons:recipes/potions/splash/select_effect
 
-# no powder snow
-execute unless score $has_powder_snow gm4_zc_data matches 1.. run function gm4_zauber_cauldrons:recipes/potions/invalid_recipe
+# water used instead of powder snow
+execute if score $has_water gm4_zc_data matches 1.. run function gm4_zauber_cauldrons:recipes/potions/invalid_recipe