From 51b2e89b5f82fb4d0492e85e0258a193f7254010 Mon Sep 17 00:00:00 2001 From: Caue Rego Date: Fri, 22 Jan 2021 02:19:18 +0000 Subject: [PATCH 1/2] use secure random for real randomness might need to still make sure it's using urandom... --- .../randomnumbergeneratorplus/utils/RandUtils.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/com/randomappsinc/randomnumbergeneratorplus/utils/RandUtils.java b/app/src/main/java/com/randomappsinc/randomnumbergeneratorplus/utils/RandUtils.java index 75305d0..d00acee 100644 --- a/app/src/main/java/com/randomappsinc/randomnumbergeneratorplus/utils/RandUtils.java +++ b/app/src/main/java/com/randomappsinc/randomnumbergeneratorplus/utils/RandUtils.java @@ -14,7 +14,7 @@ import java.util.HashSet; import java.util.List; import java.util.Locale; -import java.util.Random; +import java.security.SecureRandom; import java.util.Set; public class RandUtils { @@ -57,7 +57,7 @@ private static int generateNumInRange(int min, int max) { } private static int generateNumInPosRange(int min, int max) { - Random random = new Random(); + Random random = new SecureRandom(); return random.nextInt((max - min) + 1) + min; } From 0c5105d3c6ee312743f656ac919cd6b16701e770 Mon Sep 17 00:00:00 2001 From: Caue Rego Date: Sat, 23 Jan 2021 21:18:57 +0000 Subject: [PATCH 2/2] use u random for faster generation --- .../randomnumbergeneratorplus/utils/RandUtils.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/com/randomappsinc/randomnumbergeneratorplus/utils/RandUtils.java b/app/src/main/java/com/randomappsinc/randomnumbergeneratorplus/utils/RandUtils.java index d00acee..c1d706d 100644 --- a/app/src/main/java/com/randomappsinc/randomnumbergeneratorplus/utils/RandUtils.java +++ b/app/src/main/java/com/randomappsinc/randomnumbergeneratorplus/utils/RandUtils.java @@ -57,7 +57,12 @@ private static int generateNumInRange(int min, int max) { } private static int generateNumInPosRange(int min, int max) { - Random random = new SecureRandom(); + Random random; + try { + random = SecureRandom.getInstance("NativePRNGNonBlocking"); + } catch (NoSuchAlgorithmException nsae) { + random = new SecureRandom(); + } return random.nextInt((max - min) + 1) + min; }