Merge pull request #26 from Gelio/upgrade-deps-ts-3.8

Gelio · web-flow · commit 92901e870bd5 · 2020-03-21T15:29:51.000+01:00
Upgrade deps (TypeScript 3.8, TSLint 6.x)
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -23,17 +23,17 @@
   "author": "Grzegorz Rozdzialik <voreny.gelio@gmail.com>",
   "license": "MIT",
   "devDependencies": {
-    "@types/node": "^12.0.7",
-    "tslint": "^5.17.0",
-    "typescript": "^3.5.1"
+    "@types/node": "^12.12.30",
+    "tslint": "^6.1.0",
+    "typescript": "^3.8.3"
   },
   "homepage": "https://github.com/Gelio/tslint-react-hooks",
   "repository": {
     "type": "git",
     "url": "https://github.com/Gelio/tslint-react-hooks"
   },
   "peerDependencies": {
-    "tslint": "^5.1.0",
+    "tslint": "5 - 6",
     "typescript": ">=2.1.0"
   }
 }
diff --git a/src/react-hooks-nesting-walker/is-hook-call.ts b/src/react-hooks-nesting-walker/is-hook-call.ts
@@ -23,6 +23,7 @@ export function isHookCall(
     return true;
   } else if (
     isPropertyAccessExpression(expression) &&
+    isIdentifier(expression.name) &&
     isHookIdentifier(expression.name)
   ) {
     if (ruleOptions[detectHooksFromNonReactNamespaceOptionName]) {
diff --git a/src/react-hooks-nesting-walker/is-react-api-expression.ts b/src/react-hooks-nesting-walker/is-react-api-expression.ts
@@ -27,6 +27,7 @@ export const isReactApiExpression = (predicate: Predicate<Identifier>) => (
     return (
       isIdentifier(expression.expression) &&
       expression.expression.text === 'React' &&
+      isIdentifier(expression.name) &&
       predicate(expression.name)
     );
   }

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ export const isReactApiExpression = (predicate: Predicate<Identifier>) => (`
`27`	`27`	`return (`
`28`	`28`	`isIdentifier(expression.expression) &&`
`29`	`29`	`expression.expression.text === 'React' &&`
	`30`	`+ isIdentifier(expression.name) &&`
`30`	`31`	`predicate(expression.name)`
`31`	`32`	`);`
`32`	`33`	`}`