Upgrade make_env script to stop on error and also to allow selection of python version (#340)

delsim · Mark Gibbs · web-flow · commit 867284155da6 · 2021-06-16T12:23:39.000-07:00
Co-authored-by: Mark Gibbs &lt;mark@gibbs.consulting&gt;
diff --git a/make_env b/make_env
@@ -1,8 +1,15 @@
 #!/usr/bin/env bash
 #
-# Create a virtualenv. Note that python 3.6 is the minimal requirement
+# Create a virtualenv. Note that python 3.6 is currently the minimal requirement
 #
-virtualenv -p python3.6 env
+# Stop on error, rather than continue and trash the environment
+set -e
+#
+# Default to 3.6 but allow override
+DEFAULT_PYTHON_VER=3.6
+PYTHON_VER=${1:-$DEFAULT_PYTHON_VER}
+#
+virtualenv -p python${PYTHON_VER} env
 #
 source env/bin/activate
 #

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,15 @@`
`1`	`1`	`#!/usr/bin/env bash`
`2`	`2`	`#`
`3`		`-# Create a virtualenv. Note that python 3.6 is the minimal requirement`
	`3`	`+# Create a virtualenv. Note that python 3.6 is currently the minimal requirement`
`4`	`4`	`#`
`5`		`-virtualenv -p python3.6 env`
	`5`	`+# Stop on error, rather than continue and trash the environment`
	`6`	`+set -e`
	`7`	`+#`
	`8`	`+# Default to 3.6 but allow override`
	`9`	`+DEFAULT_PYTHON_VER=3.6`
	`10`	`+PYTHON_VER=${1:-$DEFAULT_PYTHON_VER}`
	`11`	`+#`
	`12`	`+virtualenv -p python${PYTHON_VER} env`
`6`	`13`	`#`
`7`	`14`	`source env/bin/activate`
`8`	`15`	`#`