fix(qupta-view): Add intermediate message while loading

salome-voltz · salome-voltz · commit f1356889d981 · 2024-09-20T15:20:19.000+02:00
diff --git a/package.json b/package.json
@@ -85,7 +85,8 @@
         {
           "type": "webview",
           "id": "gitguardianQuotaView",
-          "name": "quota"
+          "name": "quota",
+          "collapsed": true
         }
       ]
     },
diff --git a/src/ggshield-webview/gitguardian-quota-webview.ts b/src/ggshield-webview/gitguardian-quota-webview.ts
@@ -9,12 +9,14 @@ export class GitGuardianQuotaWebviewProvider
   private _view?: vscode.WebviewView;
   private isAuthenticated: boolean = false;
   private quota: number = 0;
+  private isLoading: boolean = false;
 
   constructor(
     private ggshieldConfiguration: GGShieldConfiguration,
     private readonly _extensionUri: vscode.Uri
   ) {
     this.checkAuthenticationStatus();
+    this.updateQuota();
   }
 
   public async resolveWebviewView(
@@ -71,6 +73,16 @@ export class GitGuardianQuotaWebviewProvider
 
     this.updateQuota();
 
+    if (this.isLoading) {
+      return `
+        <!DOCTYPE html>
+        <html lang="en">
+        <body>
+          <p>Loading...</p>
+        </body>
+        </html>`;
+    }
+
     if (this.isAuthenticated) {
       return `
         <!DOCTYPE html>
@@ -91,9 +103,13 @@ export class GitGuardianQuotaWebviewProvider
   }
 
   public async refresh() {
+    this.isLoading = true;
+    this.updateWebViewContent(this._view);
+
     await this.checkAuthenticationStatus();
     await this.updateQuota();
 
+    this.isLoading = false;
     this.updateWebViewContent(this._view);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,8 @@`
`85`	`85`	`{`
`86`	`86`	`"type": "webview",`
`87`	`87`	`"id": "gitguardianQuotaView",`
`88`		`- "name": "quota"`
	`88`	`+ "name": "quota",`
	`89`	`+ "collapsed": true`
`89`	`90`	`}`
`90`	`91`	`]`
`91`	`92`	`},`