Adding reaction goes to end of list

[Sherlouk]

When a reaction is added (tested using double tap to add, haven't validated for normal tap to add) it gets added to the end of list of reactions.

If I already have a reaction (e.g. 🎉) and then add one (e.g. 👍) it will be ordered 🎉 👍 in GitHawk UI. If I leave the issue and then re-enter it, it gets ordered based on a hardcoded array so that it renders 👍 🎉 (this is the same as GitHub's UI).

It's a very minor bug but when we insert a new reaction, we should place it respecting the order of reactions as determined in this array:

GitHawk/Classes/Issues/Comments/Reactions/ReactionsMenuViewController.swift

Lines 41 to 48 in e738618

	private let reactions: [ReactionContent] = [
	.thumbsUp,
	.hooray,
	.thumbsDown,
	.heart,
	.laugh,
	.confused
	]

[Huddie]

Agree^^^^^^^

_{Sent with GitHawk}

[j-f1]

Happens with picking from the emoji menu too.

[Architgoel4]

Hi, I'd like to pick this issue. But I'm not sure I fully understand this problem. Do we have to arrange the array based on the reactions array (ReactionMenuViewController) or based on what the user entered?
Also, it's my first time contributing to GitHub projects. I have intermediate swift knowledge.

[Huddie]

@Architgoel4 When a reaction is added, it should respect the order of the array mentioned above. Not the order it was added but the order determined by Github (and shown in that array)

[Architgoel4]

Okay, thanks @Huddie! I'll take a look at this then.

[Huddie]

@Architgoel4 still on this?

_{Sent with GitHawk}

[Architgoel4]

I am sorry, I got held up so couldn't even look at it. I'll probably won't be able to look into this for some time.

[BasThomas]

No worries @Architgoel4, thanks for the update!

I was wondering if this is done together with #2616 already? @viktorasl?

[viktorasl]

Nope, it is not.