Don't panic when suspect isn't known when converting unblamed to blame-entry

This can apparently happen, and now we handle this case and keep looking
for the remaining blame entries.

Author: Byron

gix-blame/src/file/function.rs

@@ -211,11 +211,14 @@ fn pass_blame_from_to(from: ObjectId, to: ObjectId, hunks_to_blame: &mut Vec<Unb
 /// Convert each of the unblamed hunk in `hunks_to_blame` into a [`BlameEntry`], consuming them in the process.
 /// `suspect` is expected to be present in the suspect-map in each [`UnblamedHunk`].
 fn unblamed_to_out(hunks_to_blame: &mut Vec<UnblamedHunk>, out: &mut Vec<BlameEntry>, suspect: ObjectId) {
-    out.extend(
-        hunks_to_blame
-            .drain(..)
-            .map(|hunk| BlameEntry::from_unblamed_hunk(hunk, suspect)),
-    );
+    let mut without_suspect = Vec::new();
+    out.extend(hunks_to_blame.drain(..).filter_map(|hunk| {
+        BlameEntry::from_unblamed_hunk(&hunk, suspect).or_else(|| {
+            without_suspect.push(hunk);
+            None
+        })
+    }));
+    *hunks_to_blame = without_suspect;
 }
 
 /// This function merges adjacent blame entries. It merges entries that are adjacent both in the

gix-blame/src/file/mod.rs

@@ -468,18 +468,15 @@ impl BlameEntry {
     }
 
     /// Create an offset from a portion of the *Blamed File*.
-    fn from_unblamed_hunk(mut unblamed_hunk: UnblamedHunk, commit_id: ObjectId) -> Self {
-        let range_in_source_file = unblamed_hunk
-            .suspects
-            .remove(&commit_id)
-            .expect("Private and only called when we now `commit_id` is in the suspect list");
+    fn from_unblamed_hunk(unblamed_hunk: &UnblamedHunk, commit_id: ObjectId) -> Option<Self> {
+        let range_in_source_file = unblamed_hunk.suspects.get(&commit_id)?;
 
-        Self {
+        Some(Self {
             start_in_blamed_file: unblamed_hunk.range_in_blamed_file.start,
             start_in_source_file: range_in_source_file.start,
             len: force_non_zero(range_in_source_file.len() as u32),
             commit_id,
-        }
+        })
     }
 }