Rename create_archive_if_{not_on_ci -> we_should}

This renames the private funciton `create_archive_if_not_on_ci` in
gix-testtols to `create_archive_if_we_should`, because it already
checks for much more than whether we are on CI to decide whether
or not to create the archive. This archive is also (already) not
created if we are running on Windows, if the archive destination is
excluded by being ignored in any `.gitignore`, or if Git LFS is in
use and the archive is an LFS pointer file.

Author: EliahKagan

tests/tools/src/lib.rs

@@ -569,7 +569,7 @@ fn scripted_fixture_read_only_with_args_inner(
                     output.stdout.as_bstr(),
                     output.stderr.as_bstr()
                 );
-                create_archive_if_not_on_ci(
+                create_archive_if_we_should(
                     &script_result_directory,
                     &archive_file_path,
                     script_identity_for_archive,
@@ -644,7 +644,7 @@ fn is_lfs_pointer_file(path: &Path) -> bool {
 
 /// The `script_identity` will be baked into the soon to be created `archive` as it identifies the script
 /// that created the contents of `source_dir`.
-fn create_archive_if_not_on_ci(source_dir: &Path, archive: &Path, script_identity: u32) -> std::io::Result<()> {
+fn create_archive_if_we_should(source_dir: &Path, archive: &Path, script_identity: u32) -> std::io::Result<()> {
     // On Windows, we fail to remove the meta_dir and can't do anything about it, which means tests will see more
     // in the directory than they should which makes them fail. It's probably a bad idea to generate archives on Windows
     // anyway. Either Unix is portable OR no archive is created anywhere. This also means that Windows users can't create