Commit cf21d0d
committed
Mark
The `ReadDataLineFuture` struct was among the facilities added
within `gix-packetline` in 41fdb84 (#634), and it looks like it may
have been intended to be used eventually. However, it is unused.
While it is public in `read::sidebands::async_io` module, the only
facility from that module that is exposed through `read::sidebands`
is `WithSidebands`:
https://github.com/GitoxideLabs/gitoxide/blob/04a18f3a4520dd6f49b5f87fe3782dd1cd1547f2/gix-packetline/src/read/sidebands/mod.rs#L6-L9
This situation appears to be long-standing. However, possibly
because it is public in its own directly containing module, it was
not detected as dead code by `cargo clippy` until recently.
Specifically, this caused the CI `lint` job to fail starting in the
recently released Rust 1.89. This can be observed by rerunning the
workflow where it had passed before:
https://github.com/EliahKagan/gitoxide/actions/runs/16739420509/job/47709197815
(The failure only happens in the `lean-async` run of `cargo clippy`
because the containing module is not used at all in the `max`,
`small`, and `max-pure` builds.)
For now, this commit suppresses the error by adding
`#[allow(dead_code)]` to `ReadDataLineFuture`.ReadDataLineFuture as #[allow(dead_code)]
1 parent 04a18f3 commit cf21d0d
File tree
2 files changed
+2
-0
lines changed- gix-packetline-blocking/src/read/sidebands
- gix-packetline/src/read/sidebands
2 files changed
+2
-0
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
174 | 174 | | |
175 | 175 | | |
176 | 176 | | |
| 177 | + | |
177 | 178 | | |
178 | 179 | | |
179 | 180 | | |
| |||
0 commit comments