Only fuzz test PRs that run the test suite #1609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `paths` restriction on the CIFuzz job to avoid the situation where a PR that doesn't modify anything that causes the usual tests to run on it would still run fuzz tests. (This should still have CIFuzz run even when the only change a PR makes is to adjust how CI fuzzing itself works, because one of the patterns is matched by any change to any CI workflow file.)
Byron
approved these changes
Sep 24, 2024
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot! This will save some time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
pathsrestriction on the CIFuzz job to avoid the situation where a PR that doesn't modify anything that causes the usual tests to run on it would still run fuzz tests.An example of a such a PR is #1607, where, as things are set up now, the CIFuzz job ran, taking 19 minutes, even though the only other CI jobs that needed to run there were the MSRV jobs. (I'm not entirely sure they need to run either, but it seems okay since they are rather light weight.)
Note that while #1608 also relates to a potential non-ideal CI-related behavior observed in #1607, that is unrelated to this, and this PR does not fix issue #1608.
This should still have CIFuzz run even when the only change a PR makes is to adjust how CI fuzzing itself works, because one of the patterns is matched by any change to any CI workflow file. In particular, this PR itself should be fuzzed under these rules.