mysql does not preserve dependency_info

[ylil93]

When saving a CompatibilityResult to mysql data store, dependency_info is required/included to the save, but when reading from mysql, the dependency_info field of the resulting CompatibilityResults are not set.

[liyanhui1228]

Just curious, are we still using datastore in the latest version of the badge server?

[ylil93]

Yes we are.

[liyanhui1228]

Per offline discussion, dependency_info is stored in the release_time_for_dependencies table in our MySQL database. And the issue here is that the save_compatibility_statuses function in compatibility_store is writing data to all the three tables we have in MySQL, thus it required dependency_info in the CompatibilityResult passed in to that function. But when writing tests, in some cases the CompatibilityResult doesn't contain the dependency_info, which makes the read and write to MySQL looks inconsistent.

A possible improvement could be restructure the save_compatibility_statuses function to split to three sub methods that writes to the three different tables.

[ylil93]

Thanks for the explanation! Leaving this issue open until documentation/improvements are added to the project.