Skip to content

Commit 6cdcc1f

Browse files
committed
feat: address PR feedback
- Add version specifier to functions-framework dependency - Remove --allow-unauthenticated from gcloud commands - Fix typo in Cloud Run URL - Update Cloud Run link to Cloud Functions
1 parent ad40680 commit 6cdcc1f

File tree

4 files changed

+8
-11
lines changed

4 files changed

+8
-11
lines changed

examples/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Deployment targets
44
### Cloud Run
5-
* [`cloud_run_http`](./cloud_run_http/) - Deploying an HTTP function to [Cloud Run](http.cloud.google.com/run) with the Functions Framework
5+
* [`cloud_run_http`](./cloud_run_http/) - Deploying an HTTP function to [Cloud Run](http://cloud.google.com/run) with the Functions Framework
66
* [`cloud_run_event`](./cloud_run_event/) - Deploying a CloudEvent function to [Cloud Run](http://cloud.google.com/run) with the Functions Framework
77
* [`cloud_run_cloud_events`](cloud_run_cloud_events/) - Deploying a [CloudEvent](https://github.com/cloudevents/sdk-python) function to [Cloud Run](http://cloud.google.com/run) with the Functions Framework
88
* [`cloud_run_async`](./cloud_run_async/) - Deploying asynchronous HTTP and CloudEvent functions to [Cloud Run](http://cloud.google.com/run) with the Functions Framework

examples/cloud_run_async/README.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Deploying async functions to Cloud Run
22

3-
This sample shows how to deploy asynchronous functions to [Cloud Run](http://cloud.google.com/run) with the Functions Framework. It includes examples for both HTTP and CloudEvent functions, which can be found in the `main.py` file.
3+
This sample shows how to deploy asynchronous functions to [Cloud Run functions](https://cloud.google.com/functions) with the Functions Framework. It includes examples for both HTTP and CloudEvent functions, which can be found in the `main.py` file.
44

55
## Dependencies
66
Install the dependencies for this example:
@@ -40,8 +40,7 @@ gcloud run deploy async-http-function \
4040
--source . \
4141
--function hello_async_http \
4242
--base-image python312 \
43-
--region <YOUR_REGION> \
44-
--allow-unauthenticated
43+
--region <YOUR_REGION>
4544
```
4645

4746
### CloudEvent Function
@@ -51,8 +50,8 @@ gcloud run deploy async-cloudevent-function \
5150
--function hello_async_cloudevent \
5251
--base-image python312 \
5352
--region <YOUR_REGION> \
54-
--set-env-vars=FUNCTION_SIGNATURE_TYPE=cloudevent \
55-
--allow-unauthenticated
53+
--set-env-vars=FUNCTION_SIGNATURE_TYPE=cloudevent
5654
```
5755
After deploying, you can invoke the CloudEvent function by sending an HTTP POST request with a CloudEvent payload to its URL.
56+
```
5857

examples/cloud_run_streaming_http/README.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ gcloud run deploy streaming-function \
3939
--source . \
4040
--function hello_stream \
4141
--base-image python312 \
42-
--region <YOUR_REGION> \
43-
--allow-unauthenticated
42+
--region <YOUR_REGION>
4443
```
4544

4645
### Asynchronous Streaming
@@ -49,8 +48,7 @@ gcloud run deploy streaming-async-function \
4948
--source . \
5049
--function hello_stream_async \
5150
--base-image python312 \
52-
--region <YOUR_REGION> \
53-
--allow-unauthenticated
51+
--region <YOUR_REGION>
5452
```
5553

5654
```
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
# Function dependencies
2-
functions-framework
2+
functions-framework>=3.9.2

0 commit comments

Comments
 (0)