test: update e2e test to fix gitlab push error (#1153) (#1154)

nan-yu · web-flow · commit 3b926efec9b5 · 2024-02-28T21:59:04.000Z
Gitlab doesn't allow pushing a branch with `refs/remotes/upstream/*`. It
failed with a `deny updating a hidden ref` error. This commit changes
the remote branch to just `upstream/main`, which is
`refs/heads/upstream/main`.
diff --git a/e2e/testcases/git_sync_test.go b/e2e/testcases/git_sync_test.go
@@ -35,7 +35,7 @@ func TestMultipleRemoteBranchesOutOfSync(t *testing.T) {
 	}
 
 	nt.T.Log("Create an extra remote tracking branch")
-	nt.Must(nt.RootRepos[configsync.RootSyncName].Push("HEAD:refs/remotes/upstream/main"))
+	nt.Must(nt.RootRepos[configsync.RootSyncName].Push("HEAD:upstream/main"))
 
 	nt.T.Logf("Update the remote main branch by adding a test namespace")
 	nt.Must(nt.RootRepos[configsync.RootSyncName].Add("acme/namespaces/hello/ns.yaml", fake.NamespaceObject("hello")))

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ func TestMultipleRemoteBranchesOutOfSync(t *testing.T) {`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`nt.T.Log("Create an extra remote tracking branch")`
`38`		`- nt.Must(nt.RootRepos[configsync.RootSyncName].Push("HEAD:refs/remotes/upstream/main"))`
	`38`	`+ nt.Must(nt.RootRepos[configsync.RootSyncName].Push("HEAD:upstream/main"))`
`39`	`39`
`40`	`40`	`nt.T.Logf("Update the remote main branch by adding a test namespace")`
`41`	`41`	`nt.Must(nt.RootRepos[configsync.RootSyncName].Add("acme/namespaces/hello/ns.yaml", fake.NamespaceObject("hello")))`